feat(core): implement bounded semantic crawl frontier - #2
seonghobae wants to merge 7 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Execution receipt for exact test-only head
|
Add deterministic concept-priority/FIFO dispatch, lifetime deduplication, bounded immutable candidate inputs and redacted diagnostics. Preserve the original 12 tests and add 13 boundary requirements plus a local example. Rust execution remains unverified: local cargo/rustc unavailable and the predecessor hosted job has not executed. Static source checks are not GREEN.
|
@codex review Please review exact implementation head Focus on input validation and non-mutating rejection, lifetime identity/dispatch budgets, stable priority and FIFO ordering under interleaved enqueue/dispatch, count-only diagnostics, and the distinction between planning outcomes and successful collection. The original 12 tests are retained; 13 boundary tests and a synthetic example were added. No transport, browser, model, workflow, or dependency changes accompany the implementation. Execution evidence remains unavailable: local Rust commands exited 127 (Cargo absent), and the fresh exact-head push run |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Purpose and current source
Implement Veilpick's first Rust acquisition-planning primitive under ADR 0003 without duplicating OriginWeave transport/browser authority.
556b30b9eaac083ccb52cd6c5193411df0fb81e8;docs/adr-challenge-resolution@a1cf6cf2e239b0657376890f0631267ea01b28f2;30bb16417c42f0478200b9ce2dade2bcd0d53c64and current documentation heada1cf6cf2e239b0657376890f0631267ea01b28f2;This is no longer interface-only scaffolding.
src/frontier.rscontains the production implementation andsrc/lib.rsexportsCandidate,FrontierLimits,FrontierError,FrontierStep, andCrawlFrontier. The complete product remains unshipped.Implemented source behavior
1..=256UTF-8 bytes per identifier, no Unicode whitespace/control characters, at most 128 raw concept entries before deduplication.BTreeMap<(Reverse<usize>, usize), Candidate>.BTreeSetdeduplication, including dispatched targets; duplicates never replace or reprioritize the first admitted candidate.1..=4096; draining/refilling does not reset attempts or the seen ledger.Targets are opaque acquisition references. Dispatches are not HTTP requests, authorization grants, ontology reasoning, or evidence of extraction. Stealth and supported-class automated challenge resolution remain mandatory product requirements and are not supplied by this slice.
README integration
The dependent README now carries every valid public-surface delta from PR #1 while preserving this branch's source-current Rust slice:
No standalone README writer or force-restack was created.
Tests and example
Preserve the original 12 test requirements byte-for-byte and add 13 tests in
tests/frontier_boundaries.rs(25 definitions total). Additional cases include Unicode byte limits, exact identity, duplicate goal/hint handling, interleaved scheduling, refill exhaustion, 81 small priority combinations against a separate sorted oracle, the full 4,096-target boundary, and diagnostic privacy.examples/frontier.rsdemonstrates synthetic local planning only. README, CHANGELOG, the implementation plan, anddocs/verification/semantic-frontier.mdrecord the actual source and evidence boundary.Verification evidence
Predecessor
30bb16417c42f0478200b9ce2dade2bcd0d53c64recorded nine grouped static checks and exact staged-blob matching. Those checks were not Rust compiler, test, rustfmt, Clippy, or rustdoc success; the authoring environment lacked cargo/rustc and official download attempts did not succeed.Current head
556b30b9eaac083ccb52cd6c5193411df0fb81e8was verified structurally after publication:All predecessor-hosted evidence is historical after the merge commit. New exact-head CI, Rust, security, SAST, CodeQL, Noema, OpenCode, and admission results must complete on
4361ff6…before readiness changes.Dependency, license, and merge boundary
This PR remains stacked on documentation PR #1. PR #1 must integrate first through ordinary governance; then this PR must be retargeted to the actual protected integration revision and revalidated without rewriting history.
The root Apache License 2.0 predates this slice.
Cargo.tomldeclares Apache-2.0 andCargo.lockintroduces no external package because the frontier is standard-library-only. Future dependencies and external services retain their own terms.No external runtime dependency, force push, self-approval, gate weakening, merge, release, or scheduled/background work is introduced. Keep Draft until exact-head Rust/compiler/test/format/lint/docs and required governance evidence are terminal-success and every valid finding is repaired.
Current exact authority — 2026-09-07
docs/adr-challenge-resolution@a1cf6cf2e239b0657376890f0631267ea01b28f2;556b30b9eaac083ccb52cd6c5193411df0fb81e8;Latest parent integration
Exact head
556b30b9eaac083ccb52cd6c5193411df0fb81e8is a non-force two-parent merge of README/ADR authoritya1cf6cf2e239b0657376890f0631267ea01b28f2. It preserves the semantic-frontier implementation while carrying the cancellation-boundary review repair. Earlier hosted evidence is superseded.