fix(validation): preserve representable recovery metrics - #488
Draft
seonghobae wants to merge 517 commits into
Draft
fix(validation): preserve representable recovery metrics#488seonghobae wants to merge 517 commits into
seonghobae wants to merge 517 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation Evidence authority
Protected base is
main@a243f18da4a4ca8a8d068c39922537f1f8ed6ad0. This Draft remains the owner-correct Validation Evidence landing vehicle. Productionvalidation_core::bias_standard_errorexact pair-distance admission remains deliberately bounded ton=4..=16; issue #491 owns the resource-budget decision rather than another sample-count staircase patch.GAP-125 remains the latest production behavior repair: RED
5da82b2d651706c191ca191c6c077d916cbfda25→ causal repaira509ae9e46c8ffc2cc3ef4f0e904774ad2516e1f. The exact pair-distance proof keeps exact residual/pairwise subtraction, checked dyadic/u128construction,n²(n-1)denominator, GCD reduction, exact candidate/adjacent-midpoint comparison, and fail-closed fallback.#491 exact-proof resource characterization
Common dyadic normalization remains mandatory. The superseded raw
D=2^58,n=65refusal is representation-dependent; after removing the shared unit the narrow O(n) path admits and restores exact numerator2^122. The valid narrow strict-subset boundary is oddD=2^58+1,n=65, where the pair numerator is 123 bits but the two narrow O(n) products require 129 bits before cancellation.Characterization
081000289f5a52e94863026d55696ee2a4daf923provides the dependency-free two-limbWide256reference. Characterizationb7e4da353ac58069afd73ee7c0e8427d49993fdbprovesΣc_i <= Σc_i² <= Σ(i<j)(c_i-c_j)²for canonical anchor-relative coefficients, so pair-admitted accumulator overflow is not a valid wider-path refusal hypothesis.RED
3136739460ef0c8e13c044a7e5b04891e4f4e23drequired the missingnarrow O(n) -> Wide256 O(n) -> pairwise fail-closed fallback; repairce4ed2722e160eb0ca0ee2d636a5eca55e3ff2d5adds that route tocrates/validation_core/examples/bias_se_exact_proof_budget.rs. The predecessor narrow→pair hybrid remains a comparison baseline. The harness independently recordsused_wide_productandused_pairwise_fallbackand requires exact restored-numerator equality before timing.RED
f74d9ac11cb0acf3eb8fdd9ad79ac3d2e9180993required a proof that canonical pair admission implies sufficientWide256product width; repaire9a7dee29afb97542bfe2965f850c8ab5a34368eadds it tobias_standard_error_wide_linear_admission_bound_characterization.rs. IfP <= u128::MAX, thenS1 <= S2 <= P, while supported sample count converts fromusizetou128; both cancellation products are exactu128 × u128products and fit twou128limbs. Product width alone therefore cannot makeWide256refuse a coefficient set admitted by theu128pair proof.This still does not authorize deleting pair fallback or widening production admission. Represented-residual conversion, canonical normalization, full-width subtraction, dyadic restoration, reduced denominator/midpoint rounding, release-mode resource evidence, and exact-head execution must demonstrate end-to-end equivalence first.
Hosted RED and causal repair state
Rust Foundation run
34004656803on prior source head26d727ae10a70f9798f8c9f4a30a0e745dea56bcproduced three current causal findings rather than a numerical-acceptance failure:bias_standard_error_pairwise_subtraction_roundoff_contract.rs,wilson_all_covered_extreme_z_contract.rs, andbias_standard_error_two_level_integer_divisor_rounding_contract.rs. Commit1f765a7430b3263afb7e436efdf6d3f14dd433c9adds substantive//!contract documentation to all three atomically, withoutallow(missing_docs), skip, xfail, or denominator exclusion.cargo fmt --all -- --check. The pinned read-only formatter run34004539628at source-relevant heade9a7dee29afb97542bfe2965f850c8ab5a34368ehas now produced artifact9981126289, digestsha256:94dc827376d0ab411af1be1eb309d29f3fe305bb3ac52fcda777d51bee756d9e, containingrustfmt.patch, a formatted 38-file tree, and the exact file list. Subsequent commits through the previous head changed only the Wide256 CHANGELOG/research docs; the current head additionally changes crate-level documentation in three tests, one of which overlaps that formatter tree and must preserve the new crate doc when the canonical tree is applied. The formatter delta is therefore actionable evidence, but it has not yet been applied and the format gate is not GREEN.On the same prior head, Live PostgreSQL, Documentation Quality, SAST Semgrep, and Security Scan were GREEN. CodeQL entered the central exact-head dispatch handshake: language detection and dispatch succeeded, then compatibility shards failed intentionally with
VERDICT_STATE=pendingpending authenticated central verdict/rerun. That state is neither a SARIF finding nor GREEN.Current exact source head is
1f765a7430b3263afb7e436efdf6d3f14dd433c9. Fresh Rust Foundation34009380827, Documentation Quality34009380841, SAST34009380811, Security Scan34009380833, and CodeQL34009380807are queued/current-head work and are not counted GREEN until terminal conclusions are available. The repository-contract lane remains prerequisite-bound on #492; the rustfmt lane remains local to #488.The canonical
docs/TRACEABILITY.mdstill lacks a direct #491 resource-route row. Research traceability and CHANGELOG are current through the Wide256 product-capacity proof, but the canonical matrix gap is retained rather than misreported as complete.docs/product-technical-gap-baseline.mdon #435 also requires another code-current sync after these exact-head repairs.Merge policy
Draft status is retained. No force push, destructive rebase, self-approval, required-gate weakening, mutable sibling dependency, routine admin bypass, or fabricated benchmark/CI evidence is authorized. #492 must land through normal protected-main review/Checks before its central-admission correction is considered inherited by this PR. Production admission remains
n=4..=16.