feat(analysis): bind role-contradiction refusals to an analysis-run profile - #482
Draft
seonghobae wants to merge 3 commits into
Draft
Conversation
…rofile GAP-004: cutoff-safe role_contradiction_v1 / tepp.role_contradiction.v1. Binds refuse_contradictory_roles and refuse_role_as_entity_class already on protected main. Distinct from subevent-containment, inferred-status, episode-membership, relation-absence, outcome-order, membership-target, and copy-identity. identity_recovery_rate stays library-side.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
changed the base branch from
main
to
feat/copy-identity-analysis-run-gap-004
September 2, 2026 09:01
This was referenced Sep 2, 2026
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidation status
fold_into_landing_vehicle— this cutoff-saferole_contradiction_v1profile targets #416 (feat/copy-identity-analysis-run-gap-004), not protectedmain. It changes the same Analysis Run/Validation shared Cargo/lib/docs surfaces as #416, so it remains a Draft fold child rather than independent architecture authority.Current exact source head:
506dbae236a4484301b704b6c6a05b20faf0fe69.Preserved profile evidence
role_contradiction_v1; schematepp.role_contradiction.v1.customer_competitor_cannot_share_group_role_is_not_entity_class.crates/analysis_engine/src/role_contradiction_artifact.rsplus cutoff/execution contracts and doctoring.KnowledgeCutoff::instant().MAX_EVIDENCE_UNITSbounds execution admission and artifact validation.summary.validation_statusisvalidated; the domain claim remains ininference_status.identity_recovery_rateremains library-side and inspect payloads remain metric-free.Leakage repair
Fresh source review found a historical-cutoff leak:
census_admitted_assignmentsinserted every assignment identity into the duplicate-detection set before excluding evidence whoseavailable_timewas after the knowledge cutoff. A future-unavailable assignment reusing an eligible identity could therefore change a historical run from success toDuplicateEvidence, even though that future evidence was not yet admissible.181804423d4b99448b356cf8d6dc00fcca90716daddsfuture_duplicate_identity_cannot_change_a_historical_cutoff_result, proving that a future duplicate must not alter the cutoff-bound census.506dbae236a4484301b704b6c6a05b20faf0fe69applies the availability cutoff before duplicate-identity admission. Duplicate identities among evidence actually available at the cutoff still fail closed.This ordering is part of TEPP's leakage-safe AvailableTime/knowledge-cutoff contract and must survive the eventual #416 fold. Hosted exact-head evidence must be reacquired on this new source head; predecessor checks are stale.
After retarget GitHub still reports the child as non-mergeable against #416 because the shared Cargo/lib/docs surfaces require a real conflict-resolving fold. Do not land this child independently and do not discard its source/tests/doctoring or RED/repair lineage.
ADR 0075 remains implementation lineage pending repository-wide normalization under #437; implementation maturity does not create branch-local architecture authority.
Merge authority
Only the eventual surviving #416/successor exact head counts after the fold. Reacquire all live required workflows, resolve current review threads, and satisfy the live organization ruleset's qualifying independent-review requirement on that surviving head. No self-approval, force push, routine admin bypass, or stale evidence transfer.