feat(api): resolve analysis-run identity via loopback lookup CLI - #401
Conversation
GAP-003A / issue #166: operators can jump from a 202 receipt or retry child key to a durable run_id through `tepp-analysis-runs lookup` without writing raw HTTP. Metric-free run_id/run_state/idempotency_key only. tepp.scientific_acceptance.v1 never appears. Stacked on lookup GET (#380). Does not duplicate stored-request/retry/retry-parent/cancel/create/status CLIs.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hour-25 exact-head: |
seonghobae
left a comment
There was a problem hiding this comment.
Exact-head COMMENT on a3410d4 (draft). Unique occupied: tepp-analysis-runs lookup for GET /v1/analysis-runs/by-idempotency/{idempotency_key} (ADR 0038) stacked on lookup HTTP #380 / ADR 0037. Dual-identity analysis-run lookup is occupied; do not duplicate. Metric-free identity resolution. tepp.scientific_acceptance.v1 never appears. Do not un-quarantine unscoped stored-request-by-client-key. Do not un-draft. Zero reviews on this SHA before this COMMENT. Never self-approve. Persistence remains GAP-003B. Do not weaken fail-closed. No Buyer language.
Why
GAP-003A / issue #166 still required operators to write raw HTTP/1.1 after idempotency-lookup GET. Operators cannot jump from a 202 receipt or retry child key to a durable
run_idfrom a client without scanning collection pages. Stdout stays metric-free.tepp.scientific_acceptance.v1never appears.Live slices that this PR does not duplicate:
analysis_enginescientific-acceptance librarylisted21a10579d69faf4182ef6c07004fd622983a1e)What
GAP-003A lookup CLI stacked on #380 / protected main
1bc02f580cf48e1d39da239f0e818453437c31c3:tepp-analysis-runs lookupclient ofGET /v1/analysis-runs/by-idempotency/{idempotency_key}idempotency-keyheaderrun_id/run_state/idempotency_keystdouttepp.scientific_acceptance.v1never prints--run-id, collection pagination flags, and unknown verbs fail closedNot an ADR 0014 scientific claim. Not persistence.
Verification
cargo clippy -p tepp_api --all-targets -- -D warningscargo test -p tepp_api --lib analysis_run_idempotency_lookup_clicargo test -p tepp_api --test analysis_run_idempotency_lookup_cli_contractRUSTDOCFLAGS='-D warnings' cargo doc -p tepp_api --no-depspython3 scripts/validate_documentation.pypython3 scripts/check_docstrings.pyExact head:
a3410d42d82c09dd3eb7978a54e6c46513179695Do not merge without two independent APPROVE reviews on this exact head and current Checks. Author COMMENTED is not independent APPROVE.