feat(api): poll analysis-run status from LineageWeave on loopback - #383
Conversation
Add lineageweave_analysis_run_status_exchange and a tepp-loopback TCP GET proof stacked on the ADR 0027 status path. NaruonLiveService stays POST-only.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| run_id: &str, | ||
| idempotency_key: &str, | ||
| ) -> Result<NaruonHttpExchange, ApiError> { | ||
| let mut exchange = naruon_analysis_run_status_exchange(origin, run_id, idempotency_key)?; |
There was a problem hiding this comment.
🟡 Empty status keys produce unusable requests
When the idempotency key is empty, lineageweave_analysis_run_status_exchange still returns a successful exchange. The listener rejects that generated request, so callers cannot poll the run.
| let mut exchange = naruon_analysis_run_status_exchange(origin, run_id, idempotency_key)?; | |
| crate::wire::require_nonempty(idempotency_key)?; | |
| let mut exchange = naruon_analysis_run_status_exchange(origin, run_id, idempotency_key)?; |
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Consolidation decision — closed with retired status base
This PR is not merged. Exact head
79584042369ac61a230088065d3c9c373aed383eis a one-operation consumer-parity slice stacked on now-closed #359. The generic LineageWeave status exchange and loopback TCP GET evidence are useful, but they do not warrant an independent PR or ADR after the queue circuit breaker.Fold into the coherent Analysis Run application/adapter vehicle under #166/#435 and preserve: consumer-label substitution only, own-run isolation, metric-free nonterminal status, loopback TCP GET, no GET on
NaruonLiveService, and fail-closed consumer/origin tests. The future terminal payload must use corrected Validation Evidence rather than the retired scientific-acceptance artifact.Branch/tests/reviews remain available as fold lineage.