Skip to content

test: bind restored URL and independence contract - #14

Merged
seonghobae merged 2 commits into
codex/policyweave-concurrent-writer-evidencefrom
codex/policyweave-restore-contract-bind
Sep 9, 2026
Merged

test: bind restored URL and independence contract#14
seonghobae merged 2 commits into
codex/policyweave-concurrent-writer-evidencefrom
codex/policyweave-restore-contract-bind

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Successor to PR #8 head 5309a61. Binds restored service URL survival and collecting-without-retention cross-state markers in the TypeScript restore contract so later edits cannot drop them unnoticed. Local exact-head gates GREEN: lint, 63 tests, build. CI-only Postgres evidence; no hosted adapter enablement. Merges via ordinary merge commit without force-push.

The merged restore harness already asserts service URL survival and a collecting-without-retention revision. The TypeScript contract now requires those exact markers so a later edit cannot drop them unnoticed.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-09T01:20:59.567835Z d0da193 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 746b9284-76b8-4323-8b01-10819c996751

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 878d0ce5ed

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/postgres-restore-contract.test.ts
Addresses PR #14 P2 review: the restored-URL and
collection_without_retention_count markers alone could not detect a
coupled seed+query change of revision ...0003 from retention none to
applies. The contract now requires the ...0003 none seed tuple, its
support_email item seed, and the revision-specific query predicates
together. Negative control: old markers pass the coupled mutation,
new predicates fail it; all 63 tests pass on the correct script.
@seonghobae

Copy link
Copy Markdown
Contributor Author

P2 addressed at d0da193: the contract now binds the ...0003 none seed tuple, its support_email item seed, and the revision-specific query predicates together. Negative control verified locally: old markers pass the coupled none→applies mutation, new predicates fail it; 63/63 tests pass on the correct script. Exact-head CI re-running on d0da193.

@seonghobae
seonghobae merged commit df9eef5 into codex/policyweave-concurrent-writer-evidence Sep 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant