Skip to content

fix(bidi): restore canonical cleanup formatting - #297

Merged
seonghobae merged 3 commits into
feat/webdriver-bidi-presentation-capabilitiesfrom
codex/repair-bidi-format-20260909
Sep 9, 2026
Merged

fix(bidi): restore canonical cleanup formatting#297
seonghobae merged 3 commits into
feat/webdriver-bidi-presentation-capabilitiesfrom
codex/repair-bidi-format-20260909

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Purpose

Repair the exact-head Rust contracts failure in #293 without rewriting its branch.

Root cause

cargo fmt --all -- --check rejected one non-canonical ResetTimezone struct-variant assertion. That formatting gate runs before the workspace tests, Clippy, and rustdoc.

Verification

  • cargo fmt --all -- --check
  • uv run pytest -q tests --disable-warnings --maxfail=1 — 161 passed, 546 subtests passed
  • cargo clippy --locked --workspace --all-targets --all-features -- -D warnings
  • cargo doc --locked --workspace --all-features --no-deps

Scope

One canonical formatting repair plus reusable agent guidance and an Unreleased changelog entry. Base is #293 exact head 476a8e09aa1aa7ab2e87cf7452a8ecfca47bf9c1.

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: d67b250a-6188-4e4f-90c8-445565931207

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-09T03:00:52.506260Z e027c1f Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exact-head repair finding on e027c1fb882088da0b07a33d50dd536458b4b76c: the formatting-only successor correctly repairs the ResetTimezone { context } rustfmt failure, but it also edits AGENTS.md and CLAUDE.md to teach future agents to run rustfmt. That is not part of the stated #293 formatting repair, and CLAUDE.md itself says not to edit AGENTS.md / CLAUDE.md unless the human task explicitly targets governance and the change is independently reviewed. This creates a purpose-complete self-modifying guidance delta in a source-fix PR and widens its governance surface unnecessarily. Remove the two agent-instruction file deltas (or move them to an explicitly governed independent change) while preserving the canonical Rust formatting fix and, if desired, the ordinary CHANGELOG record. Do not close #297 or rewrite #293; keep the valid formatting delta as the stacked successor. Re-run exact-head rustfmt/tests/Clippy/rustdoc after the scope repair. COMMENT only because GitHub does not permit the PR author to submit REQUEST_CHANGES on their own PR.

@seonghobae
seonghobae marked this pull request as draft September 9, 2026 03:15
@seonghobae
seonghobae marked this pull request as ready for review September 9, 2026 04:56
@seonghobae
seonghobae merged commit 6855e25 into feat/webdriver-bidi-presentation-capabilities Sep 9, 2026
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant