fix(bidi): restore canonical cleanup formatting - #297
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
seonghobae
left a comment
There was a problem hiding this comment.
Exact-head repair finding on e027c1fb882088da0b07a33d50dd536458b4b76c: the formatting-only successor correctly repairs the ResetTimezone { context } rustfmt failure, but it also edits AGENTS.md and CLAUDE.md to teach future agents to run rustfmt. That is not part of the stated #293 formatting repair, and CLAUDE.md itself says not to edit AGENTS.md / CLAUDE.md unless the human task explicitly targets governance and the change is independently reviewed. This creates a purpose-complete self-modifying guidance delta in a source-fix PR and widens its governance surface unnecessarily. Remove the two agent-instruction file deltas (or move them to an explicitly governed independent change) while preserving the canonical Rust formatting fix and, if desired, the ordinary CHANGELOG record. Do not close #297 or rewrite #293; keep the valid formatting delta as the stacked successor. Re-run exact-head rustfmt/tests/Clippy/rustdoc after the scope repair. COMMENT only because GitHub does not permit the PR author to submit REQUEST_CHANGES on their own PR.
6855e25
into
feat/webdriver-bidi-presentation-capabilities
Purpose
Repair the exact-head Rust contracts failure in #293 without rewriting its branch.
Root cause
cargo fmt --all -- --checkrejected one non-canonicalResetTimezonestruct-variant assertion. That formatting gate runs before the workspace tests, Clippy, and rustdoc.Verification
cargo fmt --all -- --checkuv run pytest -q tests --disable-warnings --maxfail=1— 161 passed, 546 subtests passedcargo clippy --locked --workspace --all-targets --all-features -- -D warningscargo doc --locked --workspace --all-features --no-depsScope
One canonical formatting repair plus reusable agent guidance and an Unreleased changelog entry. Base is #293 exact head
476a8e09aa1aa7ab2e87cf7452a8ecfca47bf9c1.