Skip to content

fix(actions): isolate MV3 PR runs #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
seonghobae wants to merge 1 commit into
base: feat/block-web-audio-fingerprinting-v3
Choose a base branch
from
Draft

fix(actions): isolate MV3 PR runs #290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/mv3-compatibility.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ name: Manifest V3 Compatibility
on:
workflow_dispatch:
pull_request:
types: [opened, synchronize, reopened, ready_for_review]
paths:
- ".github/workflows/mv3-compatibility.yml"
- "crates/originweave-core/**"
Expand All @@ -22,11 +23,12 @@ permissions:
contents: read

concurrency:
group: mv3-compatibility-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true
group: ${{ github.workflow }}-${{ github.repository }}-${{ github.event_name == 'pull_request' && github.event.pull_request.number || github.run_id }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

jobs:
chrome-for-testing:
if: ${{ github.event_name != 'pull_request' || github.event.pull_request.draft == false }}
name: Pinned Chrome for Testing MV3 fixture
runs-on: ubuntu-24.04
timeout-minutes: 20
Expand Down
14 changes: 14 additions & 0 deletions tests/test_mv3_compatibility_contract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,20 @@ def test_workflow_runs_the_real_browser_lane_without_model_credentials(self) ->
self.assertNotIn("NVIDIA_NIM_API_KEY", workflow)
self.assertNotIn("COPILOT_GITHUB_TOKEN", workflow)
self.assertNotIn("contents: write", workflow)
self.assertIn(
"types: [opened, synchronize, reopened, ready_for_review]",
workflow,
)
self.assertIn("${{ github.workflow }}-${{ github.repository }}", workflow)
self.assertIn(
"${{ github.event_name == 'pull_request' && github.event.pull_request.number || github.run_id }}",
workflow,
)
self.assertIn(
"cancel-in-progress: ${{ github.event_name == 'pull_request' }}",
workflow,
)
self.assertIn("github.event.pull_request.draft == false", workflow)

def test_doctoring_records_primary_chromium_evidence(self) -> None:
"""The exact browser baseline and non-compatibility claims must be documented."""
Expand Down
Loading