feat(network): advance document epoch from accepted BiDi navigation - #260
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
left a comment
There was a problem hiding this comment.
Exact-head CI run 33660446964 has now executed and exposed two repairable defects on 56600a6. (1) Rust contracts job 100349402191 passes repository contracts, fmt, check, and all tests, then fails Clippy because webdriver_bidi_pointer_click_send_failures.rs uses expect_err, which is denied by clippy::expect_used. This is test-code only and should be repaired without weakening the lint. (2) exact coverage artifact 9880054987 reports the only uncovered production line at webdriver_bidi_command_correlation.rs:204: the Success + absent command-id fallback. The envelope parser constructs every success with Some(required_js_uint(id)), so that branch represents an impossible internal state rather than a buyer-reachable behavior. Repair should make the envelope's success/error/event correlation state structurally typed so the impossible branch disappears; do not exclude coverage or add a synthetic test for an unconstructible state. Keep Draft until the resulting exact head is fully GREEN.
seonghobae
left a comment
There was a problem hiding this comment.
Current-head causal repair verification for d1f3a4f0f44f15b6dcdba8b8ce555af0bed89d0a. The predecessor exact head a3741389fdc491c7ecccc20f77609c55bc56d20f produced real hosted RED in both native lanes: Rust contracts job 100684518527 failed at cargo check --locked --workspace --all-targets, and Production coverage 100684518852 failed while compiling the same crate. Both logs report the same E0432: webdriver_bidi_command_correlation.rs imported the crate-private WebDriverBiDiJsonEnvelopeRouting from the crate root even though the enum is owned by webdriver_bidi_json_envelope and is intentionally pub(crate) rather than root-reexported public API. The fix keeps that visibility boundary intact and changes only the import to crate::webdriver_bidi_json_envelope::WebDriverBiDiJsonEnvelopeRouting; exact predecessor→current compare is one file, +2/-1, 0 behind. New CI 33872154944 has Rust contracts 101020424185 and Production coverage 101020423980 queued, so no GREEN is claimed yet. #261 must remain parent-first blocked until this exact head is terminal GREEN.
Signed-off-by: Seongho Bae <me@seonghobae.me>
|
Exact-head CI RCA for
The parent head remained exactly |
Signed-off-by: Seongho Bae <me@seonghobae.me>
|
Parent synchronization: exact head |
Signed-off-by: Seongho Bae <me@seonghobae.me>
|
Restacked onto exact parent PR #259 head Review correction: removed an unrelated response-routing CHANGELOG claim and replaced it with the actual buyer-visible contract: consuming an accepted navigation event revalidates the exact pre-action epoch, rotates registry authority, clears stale origin/node bindings, and cannot bind the new origin or replay the same observation. The production implementation continues to reuse the canonical Local exact-head evidence: focused document-advance tests passed; documentation contracts passed (22 tests, 177 subtests); full workspace tests passed; Clippy and rustdoc with |
Commit-Message-Assisted-by: Claude (via Claude Code) Signed-off-by: Seongho Bae <me@seonghobae.me>
|
Non-force restacked on PR #259 exact head |
Commit-Message-Assisted-by: Claude (via Claude Code) Signed-off-by: Seongho Bae <me@seonghobae.me>
|
Non-force restacked on PR #259 exact head |
Preserve document advancement, its stale-state regressions and Proposed ADR while retaining current connection-provenance composition. Restore the executable native release contract and verify complete local quality without promoting registry state to browser or origin authority. Commit-Message-Assisted-by: Codex (via Codex) Signed-off-by: Seongho Bae <me@seonghobae.me>
Replace stale current-head assertions with independently verified formatting and parent-adoption evidence for #50 and #255 through #260. Preserve dated history, source ownership, instrumentation limits, canonical scan RCA and unfulfilled hosted, reviewer and browser acceptance gates. Commit-Message-Assisted-by: Codex (via Codex) Signed-off-by: Seongho Bae <me@seonghobae.me>
Adopt #259 91d9542 without changing this branch tree, carrying the safe teardown-successor topology into document-epoch advancement. Ordinary two-parent topology adoption only; production semantics, ADR, tests, workflow, gates, and authority are unchanged. Signed-off-by: Seongho Bae <me@seonghobae.me>
Adopt #260 e522839 without changing this branch tree, carrying the safe teardown-successor topology into committed-navigation origin binding. Ordinary two-parent topology adoption only; origin validation, tests, workflow, gates, and authority are unchanged. Signed-off-by: Seongho Bae <me@seonghobae.me>
|
Writer lease RELEASED — root task 01a06c0f-b427-7830-b654-9addcdfe7aff. Published #260 3807aab over #259 180c168 by non-force push. Canonical regression RED reproduced; 18 focused tests, full Rust gates and 142 Python contracts passed; production functions/lines/regions/branches each100%. Branch-instrumentation warning disclosed. Parent receipt/fixture safeguards and child epoch production/tests/Proposed ADR preserved. Read-only review found no actionable findings. Actual Edge screenshot inspected: published evidence readable without clipping/overlap. Hosted checks remain separate; no merge or release. Source writer no longer active. |
(cherry picked from commit 8193fcd) Signed-off-by: Seongho Bae <me@seonghobae.me>
Signed-off-by: Seongho Bae <me@seonghobae.me> # Conflicts: # CHANGELOG.md # crates/originweave-network/tests/webdriver_bidi_pointer_click_response_connection_provenance.rs # docs/doctoring/webdriver-bidi-received-response-connection-provenance.md
Commit-Message-Assisted-by: Codex (via Codex) Signed-off-by: Seongho Bae <me@seonghobae.me>
Partial implementation of #28. This Draft advances only the exact registered context from the caller-captured document epoch. It does not authenticate a navigation observation, prove click causation, bind a new origin, or grant action authority.
Pointer receipt parent adoption
Exact head
3807aabeb22f9622610c3c8d504d1c686d25d896adopts #259180c168ecbdcd5eb7a4ad14ab4a53e8670646bf7by ordinary merge962ecbe4, without rewriting history.Canonical regression replay
8f6b5a0creproduced a replacement connection consuming the original pending click (0 passed, 1 failed). The parent repair restores sealed response provenance and original-connection recovery. Its receipt safeguards, regression tests and navigation fixture are unchanged here. Child document-epoch production, its two integration tests and Proposed ADR 0103 remain byte-identical to predecessore5228396. Both documentation histories are preserved.All 18 focused tests and full exact-head local Rust 1.97.1 format/check/workspace-test/strict-Clippy/rustdoc gates passed, alongside 142 Python tests, compileall, CodeGraph sync and diff checks. Pinned-nightly numerical production coverage is 100%: 1,154 functions, 11,975 lines, 15,318 regions and 1,334 branches. Artifact SHA-256:
69c6b81951e8bf338c72782361b9bb61862d0eda9de917d976c6dbbc80649fa7. The unstable branch-instrumentation warning remains visible; this is not warning-free instrumentation evidence.Independent read-only preservation review found no actionable findings, not a counted GitHub approval. Fresh hosted checks remain separate and predecessor successes do not transfer. Actual Edge screenshot inspection verified readable head/base, regression lineage, coverage and acceptance limits without observed clipping or overlap. This verifies GitHub presentation only, not browser-runtime acceptance.
Keep Draft and parent-first integration. No workflow, secret, ruleset, approval, merge, tag or release change.
Historical adoption evidence
Partial implementation of #28. This Draft consumes an admitted committed-navigation observation and advances only the exact registered session/context from the caller-captured pre-action document epoch. It does not authenticate the observation, prove click causation, bind a new origin, or grant action authority.
Current non-force stack adoption
Current exact head is
e5228396be8d9faade44a30aed704cacbeb91b46, a tree-identical ordinary two-parent adoption over predecessor2c5049aff97a90958e8262b1d403bdcbd64a1e8band current #25991d95423cf31947f691db5ebbd3072c481d86542. No source, tests, ADR, docs, workflow, dependency, gate or authority changed; the safe #255 successor topology is carried forward without rewriting history.Predecessor CI
33966229736and local 100% coverage evidence belong only to2c5049af.... Fresh exact-head CI34003322381completed success one5228396be8d9faade44a30aed704cacbeb91b46. This validates repository quality for this exact adopted tree only; it does not authenticate the observation, prove click causality, establish protected-main integration, central review/security acceptance, or release readiness.The historical E0432 import defect remains causally repaired without widening the crate-private routing enum into public API. Document-epoch advancement and stale-state rejection semantics are unchanged. Keep Draft and parent-first protected integration. No workflow/ruleset/secret mutation, self-approval, bypass, force update, destructive rebase, merge, tag, release or publication was performed.