feat(network): send bounded WebDriver BiDi session.status command - #249
feat(network): send bounded WebDriver BiDi session.status command#249seonghobae wants to merge 42 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
left a comment
There was a problem hiding this comment.
Parent-first reconstruction review: #248 4b9a04e... is now exact-head GREEN, so this child was rebuilt from that verified tree and only its four session.status command files were reapplied. This avoids carrying the predecessor parent's uncovered impossible branch or duplicating the parent repair. Fresh exact-head CI 33771106565 is still required before any child result or descendant restack can be accepted.
seonghobae
left a comment
There was a problem hiding this comment.
Superseding my earlier date correction: direct retrieval of the rendered W3C WebDriver BiDi Editor's Draft header now shows 3 September 2026. Commit 588514bfa2150381bff8f3ccbb81e6072fde6218 corrected docs/doctoring.md to that authoritative date and APA reference; commit 422ac8cce072cb016af16ed37e0de357a9ce854d restored an unrelated RFC 5280 author citation that was accidentally transcribed while replacing the whole documentation file. Current base→head remains exact #248, 0 behind, six semantic paths. Fresh CI 33859271719 is still non-terminal: Production coverage 100979703576 and Rust contracts 100979703825 are queued without runner/steps. This is a correction/verification comment, not approval or GREEN.
seonghobae
left a comment
There was a problem hiding this comment.
Parent-first stack update after this head's documentation repair: canonical common-envelope #247 has now moved to test-only 1bdfb42b35f1bda118e4b4b1a4d331db2190c3bc for the finite WebDriver BiDi ErrorCode repair. Direct parent #248 is consequently non-mergeable against its live base until that ancestor is fixed and reverified. This #249 branch remains structurally a child of the old exact #248 generation, so even if CI 33859271719 later completes successfully it can prove only this commit's own delta on that old generation, not the live parent-first stack. Keep Draft. Required continuation is #247 RED→minimal fix→exact GREEN, then non-force #248 restack+GREEN, then non-force #249 restack+fresh GREEN. Do not copy the common ErrorCode rule into this command sender or force-push. This is a dependency note, not approval.
Signed-off-by: Seongho Bae <me@seonghobae.me>
|
Current-parent reconstruction and exact-head RCA on
This PR remains draft and stacked on #248. |
Commit-Message-Assisted-by: Claude (via Claude Code) Signed-off-by: Seongho Bae <me@seonghobae.me>
Commit-Message-Assisted-by: Claude (via Claude Code) Signed-off-by: Seongho Bae <me@seonghobae.me>
|
Exact-head repair evidence for
The newly queued GitHub checks remain authoritative for this changed head; this comment does not claim protected merge or shipment. |
Commit-Message-Assisted-by: Claude (via Claude Code) Signed-off-by: Seongho Bae <me@seonghobae.me>
|
Exact-head child refresh evidence for
|
Commit-Message-Assisted-by: Claude (via Claude Code) Signed-off-by: Seongho Bae <me@seonghobae.me>
|
Verified PR #248 current exact head |
seonghobae
left a comment
There was a problem hiding this comment.
Exact-head focused review for stacked child 017d6e816f5a86544a63821b3ceaba94d5f17f44 over parent #248 7d6db16b2ead201fcec320854923f90d3ad0d8bc: no actionable defect found in the bounded session.status sender. The command has static method/params serialization, enforces the WebDriver BiDi js-uint ceiling, registers typed correlation before I/O, rejects invalid deadlines before registration, retires only proven preflight failures, and consumes the established stream on ambiguous write failure. Local exact-head evidence: rustfmt passed; all 5 focused integration tests passed; strict all-target/all-feature Clippy passed. Keep Draft and parent-first: its two hosted checks are queued and #248 has not reached protected main.
Update the live queue to 12 Ready and 113 Draft PRs after #248's parent repair. Preserve the zero-test RED, exact local gates and coverage, current parent lineage, and #249's remaining dependency adoption without claiming hosted or protected delivery. Commit-Message-Assisted-by: Codex (via Codex) Signed-off-by: Seongho Bae <me@seonghobae.me>
Preserve the session-status sender and Rust tests while integrating the owning fixture and native release-check repairs. Retain both conflicting changelog entries and record exact ancestry and discovery evidence. Commit-Message-Assisted-by: Codex (via Codex) Signed-off-by: Seongho Bae <me@seonghobae.me>
Preserve the five status-response owner blobs while merging the canonical opening fixture and discoverable correlation release contract from current #249. Verify the integrated tree without transferring predecessor hosted evidence. Commit-Message-Assisted-by: Codex (via Codex) Signed-off-by: Seongho Bae <me@seonghobae.me>
|
session.status sender connection-provenance writer RELEASED — 2026-09-06 21:09 UTC Normal publication advanced #249 from Fresh exact-head CI Acquisition recordBounded source lease was acquired on #249 exact head |
|
session.status prerequisite-repair writer acquired — 2026-09-06 21:29 UTC Fresh exact-head evidence changed the state after the prior release: #249 is This lease is bounded to repairing that missing prerequisite without reverting the executed same-session replacement-socket security requirement. I will add only the private per-connection provenance needed by the existing sender/consumer contract, with realistic tests and no public caller-supplied generation, then re-run exact-head gates. No workflow/ruleset/secret mutation, force update, destructive rebase, merge, tag, release or approval substitution. #250 remains read-only while this parent repair is active. Explicit release follows publication/verification or defer. |
|
session.status prerequisite-repair writer RELEASED — 2026-09-06 21:42 UTC The bounded writer acquired in The executed predecessor failure remains CI Fresh CI PR body now records the executed RED, causal repair and current pending boundary. #250 remains read-only and should adopt this exact parent only after actual execution/verification, then separately close its missing received-message prerequisite. No workflow/ruleset/secret change, force update, destructive rebase, self-approval, protected merge, tag or release. No #249 source/docs writer remains here. |
|
session.status parent-scope writer acquired — exact Fresh hosted execution of CI This bounded lease removes only those unused receive-side methods from #249 while preserving the optional private sender generation, connection-generation allocator/exhaustion contract, generic correlation path, all histories and #250 read-only. No workflow/ruleset/secret mutation, force update, destructive rebase, gate weakening, protected merge, tag or release. Publication will be ordinary, followed by exact-head readback and explicit release; new hosted checks remain required before GREEN. |
|
session.status parent-scope writer RELEASED — 2026-09-06 22:34 UTC This bounded #249 writer releases after normal publication and readback verification of exact Fresh CI No source/docs/ref writer remains with this task for #249. Any child adoption must first acquire its own fresh lease and preserve its unique response-provenance delta by ordinary non-force integration. |
|
Exact-head hosted evidence checkpoint — evidence-only PR-state lease acquired after fresh coordination confirmed the #249 source writer is RELEASED and no later unreleased #249 lease; released in this same checkpoint with no source/docs/ref mutation. Exact current head No workflow/ruleset/secret/gate change, force update, source write, protected merge, tag or release occurred. No #249 writer remains held after this checkpoint. |
Current session.status sender prerequisite repair — 2026-09-08
Exact head
65ac3ab94daceebd8843c0727676fbbd71200256on exact #248 baseb386f17c4826adabebda084bff2fba35aee94dd0; Draft. The branch remains an ordinary non-force descendant of the original typedsession.statussender and preserves the executed sender connection-provenance prerequisite introduced at583ffee2ee471bdb49762225d810ff9b5d6a9a77.Executed RED and minimal parent-scope correction
CI
34061733042actually executed exact583ffee2...; it was not queued evidence. Rust contracts101563339058passed all 142 Python repository contracts, rustfmt, workspace check and the full workspace tests, then failed strict Clippy only because two receive-side helpers inwebdriver_bidi_command_correlation.rswere dead code on this parent:correlate_response_for_connectioncomplete_on_connectionThose helpers consume received-connection provenance and belong to child #250's response-provenance slice. Parent #249 only needs the sender-side prerequisite already used by
session.statusbefore I/O: process-local verified connection generation plus connection-bound command registration. Production coverage101563338988also failed on the same exact head, but its job log was not available through the evidence path at that checkpoint, so no unsupported coverage root-cause claim is made.65ac3ab...is one ordinary commit ahead of583ffee2...and changes onlycrates/originweave-network/src/webdriver_bidi_command_correlation.rs. It removes those two unused receive-side consuming methods from the parent while retaining:WebDriverBiDiConnectionGenerationprovenance on outstanding commands;register_command_for_connection(...)for sender-side binding before I/O;The comments make the ownership split explicit: generic parent correlation does not claim received-connection provenance; a child slice that owns received transport evidence supplies the connection-sensitive consuming boundary. No command family, subscription intent, teardown semantics, raw dispatcher, caller-supplied generation, workflow, ruleset, secret or gate change is included.
Exact-head GREEN — 2026-09-08
Fresh readback shows CI
34064314535completed success on unchanged exact65ac3ab94daceebd8843c0727676fbbd71200256. Production coverage job101570292594passed measurement, diagnostics upload and exact production coverage enforcement. Rust contracts job101570292728passed Python repository contracts, canonical formatting, workspace check, full tests, strict Clippy and warnings-denied API documentation. The earlier queued description is therefore stale and is superseded by this exact-head terminal evidence.This GREEN validates only #249's sender-side prerequisite. Child #250 already owns the receive-side replacement-connection provenance boundary and must remain independently verified on its own exact head; protocol write success remains distinct from received response provenance, Chromium authentication, browser post-condition, protected-main delivery and release eligibility.
Keep Draft and parent-first. No workflow/ruleset/secret mutation, force update, destructive rebase, self-approval, protected merge, tag or release is part of this repair.
Historical executed prerequisite checkpoint
Exact
583ffee2ee471bdb49762225d810ff9b5d6a9a77restored the sender connection-generation prerequisite after predecessore77150f4de6534887098fb9de7e02ecea7fbb59cexposed the missing shared API. CI34061733042later demonstrated that the parent had also inherited two receive-only helpers that strict Clippy correctly rejected as unused.65ac3ab...is the minimal ownership correction of that executed RED.Historical pre-provenance checkpoint
Exact
84b9407978ae0f6c115f01170b6069c601b21104on #248b386f17c4826adabebda084bff2fba35aee94dd0passed native CI33954334610before sender connection provenance was introduced. It remains historical repository-quality evidence only and does not validate later provenance heads.