fix(migration): harden governed handoff runtime integrity - #71
fix(migration): harden governed handoff runtime integrity#71seonghobae wants to merge 8 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough마이그레이션 핸드오프가 정확한 내장 타입을 요구하도록 변경되었습니다. 사용자 정의 서브클래스의 위조 동작을 거부하는 회귀 테스트와 검증 기준 문서가 추가되었습니다. Changes런타임 증거 무결성
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This change hardens migration handoff runtime validation without introducing a supported merge-readiness concern; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
@opencode-agent Please review the current unchanged head against protected |
_require_exact_text guarantees exact str before UUID(value), so only ValueError can escape; AttributeError/TypeError arms were unreachable after the runtime-integrity guard landed. Addresses Devin review observation on PR #71.
Preserve the migration-handoff runtime-integrity repair while adopting protected develop@eb9757f without restoring package-local CI or bypassing the canonical Foundation workflow.
1 participant
Buyer-visible scope
This Orgmetra-only migration-adapter repair prevents caller-controlled runtime subclasses from forging governed handoff evidence before an HRIS migration is executed. It owns only Orgmetra's value-free pre-write governance envelope; it does not copy MHTML ETL Gateway or mightyETL runtime behavior, mutate either repository, or introduce cross-service application-table SQL.
RED → causal repair retained
8d794f1394f99bee4086da59a208bb46a6cad9b1added adversarial regressions for forged governance text, dependency revisions, target-object allow-list membership, numeric bounds, and fixed envelope state.54bcef13194e7f9bbe38c9d7a916fd0825f0ae4frequires exact built-in trust primitives before reviewed equality, membership, bounds, UUID parsing, regex validation, or canonical evidence serialization.1d7ed5bbfb18b35d589c69a6e8d93754ba299589narrows UUID parsing failure handling to the actualValueErrorcontract.Protected-parent adoption and dependency authority
Protected-parent adoption snapshot is
develop@eb9757f8649aaad026a9865508d9aad50c1a7a4f. GitHub's synthetic mergedf043ec75c783beb7bfe98b323bec1018228fa05was inspected before adoption: parents weredevelop@eb9757f...and feature1d7ed5bb..., treea0fba1b4797f1ed3fc9f01d8656e69bfc6542dc2, and the exact workflow inventory contained only canonicalfoundation-ci.ymlandrecovery-rehearsal-quality.yml. The branch advanced without force to two-parent successord636ac4abb4b61a8f3ab9f217a9b843eb1562ece.A follow-up release/traceability sweep found a separate dependency-authority defect. MHTML ETL Gateway revision
779254927abb1e7cee80fd949907ccd03f9fc7beis correctly bound to immutable releasev0.4.0. The reviewed mightyETL revisionba8911f50ed20a39927a0d51c0cf20f9b7c91820, however, has no published owner release. Orgmetra therefore may retain it as reviewed design/proposal evidence while Draft but must not describe it as a published production dependency or complete release acceptance against it. Issue #256 owns the required owner-release → consumer version/provenance binding sequence.Ordinary successor
883c4bc9dc62b712de5f2a355251d405d2810957repairs only that authority/traceability surface:docs/doctoring/migration-handoff-references.mdnow cites MHTMLv0.4.0as the immutable release and labels mightyETL as an unreleased source snapshot;docs/traceability/migration-handoff.mdreplaces the stale package-local quality-workflow claim with canonical Foundation CI and records #256 as a release prerequisite; the migration-adapter module docstring/comment no longer claims the mightyETL snapshot is a published owner contract. Runtime validation, record bounds, target allow-list, envelope schema and migration semantics are unchanged.Current acceptance
GitHub records exact head
883c4bc9dc62b712de5f2a355251d405d2810957with basedevelop@eb9757f...; the PR remains open · Draft and mechanically mergeable. Foundation34018193669is now terminal SUCCESS on this exact head. SAST34018193647, CodeQL34018193653, and Security34018193696remain queued/non-terminal, so the lane is not review-ready and no predecessor result is transferred.On predecessor
d636ac4a..., Foundation34015590713reached terminal SUCCESS before the authority repair. SAST/Security/CodeQL were still queued when the successor was created. That predecessor Foundation result establishes that the protected-parent adoption itself was viable, but it is not GREEN for883c4bc9....Merge/release acceptance now requires both exact-head Orgmetra gates/review and #256's immutable mightyETL owner-release binding. Do not self-approve, use routine administrator bypass, synthesize missing verdicts, promote a bare foreign commit to released-contract status, no-op retrigger, force-push/destructively rebase, or Close the valid migration-integrity delta.