Skip to content

docs(copy): speak customer actions instead of internals - #123

Draft
seonghobae wants to merge 2 commits into
developfrom
chore/customer-copy-audit
Draft

docs(copy): speak customer actions instead of internals#123
seonghobae wants to merge 2 commits into
developfrom
chore/customer-copy-audit

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Current authority — 2026-09-06

Current exact head is 740cbec81ab43464cc4ae9c7a6f34b523426f9c1. This PR still carries old base snapshot develop@9e3e4847510e1e612b48474ba42b177b8ed824df; live protected truth is develop@eb9757f8649aaad026a9865508d9aad50c1a7a4f. GitHub currently reports the PR open · Draft · non-mergeable. Earlier wording that called it non-draft and mechanically mergeable was stale and is removed here.

The product-copy delta remains valid: customer guidance replaces internal storage/implementation jargon with concrete next actions across candidate-evidence, offer-approval, requisition-review, HRIS-kernel correction/assignment/workforce/organization/resolution messages, People API hire/worker-conflict errors, and the storyboard. Trust semantics remain unchanged: authoritative re-resolution precedes consequential use, human-only approval remains mandatory where the owning flow requires it, and fail-closed behavior is preserved. Published route placeholders, Keyverse, and external-owner adapter names remain where they are real contract truth rather than implementation leakage.

Protected governance correction

The prior body also recorded a required_approving_review_count = 0 target. That is not the live protected rule. Organization ruleset 18156473 is active on the default branch and currently requires 1 approving review, dismisses stale reviews after a push, requires review-thread resolution, requires extra approval for unattributed changes, permits merge/squash only, and requires the seven central OpenCode / PR scheduler / Security / Strix / SAST / Noema / CodeQL workflows. The exposed OrganizationAdmin bypass is not an ordinary merge path and must not be used to make this lane pass.

Historical exact-head evidence

The old-base exact head previously had successful repository-owned evidence but terminal non-passing review evidence, including OpenCode run 33209166811 / job 98978056409 and Strix run 33209166866 / job 98980447535. Existing thread closure or historical checks do not transfer across a protected-parent reconciliation, and no qualifying approval may be inferred from COMMENTED reviews.

Required repair path

Preserve the customer-action copy delta and its tests, semantically adopt current protected develop without force/destructive rebase, preserve #161 canonical workflow ownership, resolve any overlapping source/provenance changes rather than choosing an old tree wholesale, and reseal deterministic artifacts from final bytes where required. Only the reconciled successor may obtain fresh exact-head Foundation/security/review evidence and the live ruleset's qualifying approval.

Do not self-approve, use routine administrator bypass, manufacture reviewer identity, transfer predecessor GREEN, weaken or simulate a required workflow, force-push, or simply Close the valid copy delta.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2f6a61ad-ba2a-4524-807e-e4778cbe832e

📥 Commits

Reviewing files that changed from the base of the PR and between 9e3e484 and 382a46a.

📒 Files selected for processing (16)
  • docs/STORYBOARD.md
  • manifest.json
  • packages/candidate-evidence/src/orgmetra_candidate_evidence/packet.py
  • packages/candidate-evidence/tests/test_packet.py
  • packages/candidate-evidence/tests/test_tenant_scope.py
  • packages/hris-kernel/src/orgmetra_hris_kernel/assignment.py
  • packages/hris-kernel/src/orgmetra_hris_kernel/correction.py
  • packages/hris-kernel/src/orgmetra_hris_kernel/organization.py
  • packages/hris-kernel/src/orgmetra_hris_kernel/resolution.py
  • packages/hris-kernel/src/orgmetra_hris_kernel/workforce.py
  • packages/offer-approval/src/orgmetra_offer_approval/packet.py
  • packages/offer-approval/tests/test_actor_separation.py
  • packages/requisition-review/src/orgmetra_requisition_review/packet.py
  • packages/requisition-review/tests/test_packet.py
  • services/people-api/src/orgmetra_people_api/hire_http.py
  • services/people-api/src/orgmetra_people_api/http.py

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

패킷 검증 지침, HRIS 충돌 안내, People API 오류 응답, 후보자-근로자 전환 문서의 표현을 갱신했습니다. 관련 테스트 기대값과 manifest의 문서 다이제스트도 업데이트했습니다.

Changes

기록 무결성 안내

Layer / File(s) Summary
패킷 참조 및 행위자 검증 안내
packages/candidate-evidence/..., packages/offer-approval/..., packages/requisition-review/...
패킷 참조를 테넌트의 authoritative source에서 재해결하도록 안내를 변경했습니다. requester와 approver의 actor identity 분리 조건을 명시했습니다. 관련 테스트 기대값을 갱신했습니다.
HRIS 기록 충돌 안내
packages/hris-kernel/src/orgmetra_hris_kernel/*
고용 버전, 기록 구간, 조직 계층, 단일 값 사실, assignment 충돌의 next_action 문구를 갱신했습니다.
API 오류 응답 및 기록 문서
services/people-api/src/orgmetra_people_api/*, docs/STORYBOARD.md, manifest.json
Hire 및 People API 오류 메시지를 갱신했습니다. 후보자-근로자 전환 설명과 문서 manifest의 SHA-256 다이제스트 및 바이트 수를 갱신했습니다.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 382a4

The PR updates customer-facing wording and related assertions while preserving the stated behavior, with all reported checks passing; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 90.91% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 14 files. (2 skipped: 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 내부 용어를 제거하고 고객의 다음 조치를 명확히 표현하는 주요 변경 사항을 정확하고 간결하게 설명합니다.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/customer-copy-audit

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

This report is out of date. Scroll down for Devin Review's latest report on this PR.

Devin Review found 0 potential issues.

Open in Devin Review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 0 new potential issues.

Devin Review

Copy link
Copy Markdown
Contributor Author

@opencode-agent review

Please produce a formal APPROVED or CHANGES_REQUESTED review bound to exact current head 740cbec81ab43464cc4ae9c7a6f34b523426f9c1 against develop@9e3e4847510e1e612b48474ba42b177b8ed824df. Use the existing central ContextualWisdomLab/contextual-orchestrator integration with the orchestrator/free pool. Review only: do not update the branch, merge, self-approve, weaken or bypass any review/security/coverage gate, or transfer predecessor evidence to this head.

Copy link
Copy Markdown
Contributor Author

Lifecycle/mergeability correction: current protected develop is eb9757f8649aaad026a9865508d9aad50c1a7a4f, while this copy lane remains on 9e3e484.... GitHub now reports the live PR non-mergeable, and it has been returned to Draft. Preserve the buyer-facing copy delta and its trust semantics; do not resolve this by choosing one side of the conflict or discarding later protected People/HRIS/documentation truth. Reconciliation must non-force adopt current protected truth, resolve each affected customer-facing message/storyboard contract against the current owner implementation, regenerate deterministic manifest/provenance from final bytes, and obtain fresh exact-head checks/review. The body’s non-draft/mechanically-mergeable statement is superseded by this correction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant