feat(talent): connect accepted offer evidence to confirmed-hire authority - #108
Draft
seonghobae wants to merge 22 commits into
Draft
feat(talent): connect accepted offer evidence to confirmed-hire authority#108seonghobae wants to merge 22 commits into
seonghobae wants to merge 22 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 24, 2026
seonghobae
marked this pull request as ready for review
August 25, 2026 23:30
seonghobae
marked this pull request as draft
August 26, 2026 18:05
seonghobae
added a commit
that referenced
this pull request
Sep 6, 2026
Preserve the complete governed candidate-offer response evidence delta from a72463a while adopting protected develop@eb9757f8649aaad026a9865508d9aad50c1a7a4f using GitHub's conflict-free exact merge tree. Preserve #161 repository-workflow consolidation and keep dependency-first child #108 unmerged until this parent integrates normally. No force-push, gate weakening, foreign-owner source copy, or release claim.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buyer-visible gap
PR #80 adds candidate-originated offer acceptance/decline evidence but deliberately leaves it non-authorizing. Protected
developalready has the authoritativeaccept_confirmed_hire(...)mutation path. This stacked Orgmetra-only lane closes the application-layer gap between those boundaries without turning a candidate response into hire authority.Test-first repair sequence
Initial contract head
d9775c3d233e8496e66581f890c918df7f919b38added only the offer-to-hire regression whileorgmetra_people_api.offer_closewas absent. No terminal hosted RED is claimed because that head was superseded before an exact run materialized.The implementation validates an exact canonical
CandidateOfferResponsePacket; rejectsoffer_declinedbefore protected resolution or persistence; requires purpose-boundmaterialize_workerauthorization before protected candidate/offer authority resolution; re-resolves the opaque candidate profile, external candidate actor, identity-resolution provenance, exact offer approval/terms provenance and immutable selection decision throughCandidateOfferHireAuthority; binds those facts in a redactedCandidateOfferHireVerification; revalidates candidate-response evidence after authority work; and only then delegates to existingaccept_confirmed_hire(...), which independently reauthorizes immediately before mutation.Regression
e8a2726bafc34051c9d568b9d1e92ba66f96d774exposed a privacy/authorization-order defect in the first implementation. Repairs21e992df613770c5b269f50c8fc606ec57260e73andd15d20e3533ab486656bde92baafa7138f96165bmoved purpose-bound authorization ahead of the protected resolver while preserving envelope validation.Fresh dependency / ancestry state
Current parent #80 exact head:
c62dd2c536b8b2e10a4912e34637e8dcf0d8fdf8.Current child #108 exact head:
d465d1cd34ec3eeaee863535a7a4142cd018e06b.Recorded child base:
feat/candidate-offer-response-evidence@5070f34cd13814f09d74162347f837cb34d76a57.Parent #80 first non-force adopted protected
develop@eb9757f8649aaad026a9865508d9aad50c1a7a4fatb9d09ba2.... Fresh Foundation run34005884590then exposed a real runner/inventory RED because the adopted feature tree resurrected a package-local workflow that protected #161 had consolidated. Parent successorc62dd2c...retires that leaf workflow and preserves the candidate-response SHA-256-bound installed-wheel/isolated-toolchain 100% coverage contract inside canonical Foundation CI; its fresh current-head gates are still non-terminal. The child intentionally remains on its recorded older parent snapshot.Historical
Offer To Hire Close Qualityrun33180159995is GREEN on exact childd465d1cd...; the lane-local suite passes 12 tests with 100% statement/branch coverage (106/30), plus compileall, Ruff, actionlint and diff checks. This is child/predecessor evidence only and does not prove compatibility with current parentc62dd2c..., protecteddevelop, or current central controls.Stack / ownership / merge governance
Normal order is: #80
c62dd2c...fresh exact-head acceptance and independent review → #80 normal protected integration → #108 non-force adoption/retarget preserving its complete valid delta and all parent-owned candidate-response evidence → fresh child People/Foundation/SAST/Security/Recovery and central reviewer acceptance on one resulting exact head.people-apiremains the owner of authoritative confirmed-hire authorization/mutation. Keyverse and every other dedicated-writer CWL repository remain read-only; no cross-service application-table SQL is introduced.Ruleset
18156473requires one approving review, dismisses stale approvals on push, requires review-thread resolution, can require an extra approval for unattributed changes, and requires the central workflow set. Do not restack onto mutable #80 merely to manufacture descendant evidence; do not self-approve, use routine administrator bypass, transfer parent/predecessor evidence, force-push/destructively rebase, or mutate a dedicated-writer dependency.