fix(chat): preserve null timeouts and attribute worker expiry - #974
Open
seonghobae wants to merge 2 commits into
Open
fix(chat): preserve null timeouts and attribute worker expiry#974seonghobae wants to merge 2 commits into
seonghobae wants to merge 2 commits into
Conversation
|
Warning Review limit reachedNext included review available in 42 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (10)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
changed the title
This was referenced Sep 7, 2026
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
OpenCode reviewed the current-head product diff. Coverage is a separate gate.
Changed files
AGENTS.md— repository behaviorbackend/app/global_ask_queue.py— API and service runtimebackend/app/main.py— API and service runtimedocs/adr/0083-orchestrator-runtime-commit-pin.md— operator or user guidancedocs/product-technical-gap-baseline.md— operator or user guidancelineageweave/http_client.py— Python module behaviorlineageweave/post_chat.py— Python module behaviortests/test_global_ask_queue.py— regression suitetests/test_http_client.py— regression suitetests/test_post_chat.py— regression suite
Changed behavior
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Repository file: AGENTS.md"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Repository file: AGENTS.md"]
R1 --> V1["required checks"]
Evidence --> S2["Backend: global_ask_queue.py (2 files)"]
S2 --> I2["API and service runtime"]
I2 --> R2["Review risk: Backend: global_ask_queue.py (2 files)"]
R2 --> V2["backend tests"]
Evidence --> S3["Docs: 0083-orchestrator-runtime-commit-pin.md (2 files)"]
S3 --> I3["operator or user guidance"]
I3 --> R3["Review risk: Docs: 0083-orchestrator-runtime-commit-pin.md (2 files)"]
R3 --> V3["docs review"]
Evidence --> S4["Python: http_client.py (2 files)"]
S4 --> I4["Python module behavior"]
I4 --> R4["Review risk: Python: http_client.py (2 files)"]
R4 --> V4["pytest plus coverage"]
Evidence --> S5["Test: test_global_ask_queue.py (3 files)"]
S5 --> I5["regression suite"]
I5 --> R5["Review risk: Test: test_global_ask_queue.py (3 files)"]
R5 --> V5["targeted test run"]
Findings
No source-backed product finding is synthesized from the coverage gate. A coverage miss belongs in the status comment.
- Head SHA:
def15fc691d4442c0d82103c1642147b1528d7be - Workflow run: 34111705214
- Workflow attempt: 1
- Coverage gate:
failure
Review outcome
Coverage is a gate, not the review. This body reviews the changed product files.
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Repository file: AGENTS.md"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Repository file: AGENTS.md"]
R1 --> V1["required checks"]
Evidence --> S2["Backend: global_ask_queue.py (2 files)"]
S2 --> I2["API and service runtime"]
I2 --> R2["Review risk: Backend: global_ask_queue.py (2 files)"]
R2 --> V2["backend tests"]
Evidence --> S3["Docs: 0083-orchestrator-runtime-commit-pin.md (2 files)"]
S3 --> I3["operator or user guidance"]
I3 --> R3["Review risk: Docs: 0083-orchestrator-runtime-commit-pin.md (2 files)"]
R3 --> V3["docs review"]
Evidence --> S4["Python: http_client.py (2 files)"]
S4 --> I4["Python module behavior"]
I4 --> R4["Review risk: Python: http_client.py (2 files)"]
R4 --> V4["pytest plus coverage"]
Evidence --> S5["Test: test_global_ask_queue.py (3 files)"]
S5 --> I5["regression suite"]
I5 --> R5["Review risk: Test: test_global_ask_queue.py (3 files)"]
R5 --> V5["targeted test run"]
Contributor
OpenCode Review Overview
Coverage evidence did not pass, so approval is blocked. The formal pull-request review is the source-backed diff review, not this status comment. |
seonghobae
enabled auto-merge (squash)
September 8, 2026 02:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post chat silently applied a 180-second model transport limit, including when the factory received explicit null. Separately, Ask classified an immediate upstream
TimeoutErroras expiry of its 600-second worker timer.Default the post-chat transport to null and preserve omitted/null/explicit seconds through its factory and shared HTTP boundary. Use the native asyncio timeout context's expiration state to attribute only actual worker expiry; provider failures retain ADR 0123's bounded unavailable response, and shutdown cancellation propagates without failed settlement. ADR 0083 records the transport-default amendment as Proposed, with its existing Accepted runtime pin unchanged.
Validation on exact head
def15fc691d4442c0d82103c1642147b1528d7be:34087424307are terminal GREEN: PostgreSQL-backed full suite and frontend lint/test/production-build/Storybook passed.34087424256and Security34087424295are now terminal GREEN on the same head.34087424233is terminal fail-closed, not a source finding. Language detection succeeded; Python, JavaScript/TypeScript, and Actions compatibility jobs successfully dispatched current-head scans, then failed atRelease runner or enforce current-head CodeQL verdictbecause the authenticatedcodeql-dispatch/*verdict was stillpending. The job explicitly records that the dispatcher is expected to publish a terminal verdict and rerun the exact failed job. Do not replace this with a synthetic status or leaf head churn.Remaining scope: Ask still explicitly supplies a 570-second socket limit and enforces a 600-second execution deadline. Age-based orphan recovery and settlement require execution-owner fencing; remove those limits only with a liveness/recovery contract. Null socket timeouts do not establish cancellation of blocking network work. Other model clients require separate verification.
The contextual-orchestrator #1053 contract inspected at
a95d3c8c1160c821d4e1ed7a2fbe50eaed176b7fremains Draft: it stores/reads timeout policy but explicitly reports enforcement unavailable. No open upstream PR is treated as a released runtime.Direct descendant #979 is the #975 ownership-fencing lane and remains dependent on this exact parent. Keep this PR Ready for Review but do not merge until required CodeQL has a terminal authenticated GREEN and qualifying independent approval exists. No self-approval, gate weakening, deployment, or live-provider acceptance is claimed.