feat(reports): leftover-map axis share on leftover-map comparison graphic leftover-map axis ticks independently of leftover-map singular values (v2.88.0) - #872
Conversation
…phic leftover-map axis ticks independently of leftover-map singular values (v2.88.0) Caption leftover-map comparison graphic leftover-map axis ticks with persisted leftover-map axis share through leftoverMapComparePlotTickAxisBadge independently of leftover-map singular values (ADR 0331). Share and σ omit independently. Rank-0 unused axes still name leftover-map axis share 0%. Leftover-map graphic leftover-map axis ticks, leftover-map comparison leftover-axis ticks, and leftover-axis ticks stay σ-only. Do not invent leftover-map axis share from σ_k. Do not invent σ_k from leftover-map axis share. Never invent a leftover score or a theta. No new columns.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Leave open for independent APPROVE. Do not self-approve. Frontend lint is green; Full test suite still running. After independent review, retarget onto leftover-coordinates rather than squash-merging onto the leftover base.
|
Cycle write probe 2026-08-31T05:25Z: retry GitHub writes before next leftover-map buyer gap. Independent APPROVE still required on exact head 7bdc562. Do not self-approve. |
|
Cycle 2026-08-31T05:24Z: writes retry on #872. Independent APPROVE still required on this leftover-map comparison graphic leftover-map axis tick leftover-map axis share increment (v2.88.0 / ADR 0331). Do not self-approve. Do not squash leftover stack onto unprotected leftover base. Next stacked increment is leftover-map graphic leftover-map axis ticks with leftover-map axis share independently of leftover-map singular values (leftoverMapPlotTickAxisBadge, v2.89.0 / ADR 0332) onto this head. Issues #79 and #87 stay open. Do not merge #808 without independent APPROVE. |
|
Cycle note (2026-08-31 15:24 KST): leftover-map stack continues. Next increment ADR 0334 / v2.91.0 leftover-axis tick leftover-map axis share. Do not self-approve. Do not squash-merge this stack onto unprotected leftover base. |
seonghobae
added
enhancement
ChatGPT Codex Connector
1 participant
Summary
make seed, leftover-map comparison graphic leftover-map axis ticks name persisted leftover-map axis share when leftoverMapComparePlotTickAxisBadge returns a usable leftover-map axis tick leftover-map axis share caption even when leftover-map singular values are omitted; click a leftover pair opens that post.leftover map comparison graphic leftover-map axis {k} tick {value} {share}%when leftover-map axis share is finite andσ_komits, andleftover map comparison graphic leftover-map axis {k} tick {value} σ {singular} {share}%when both are finite so they stay distinct from leftover-map graphic leftover-map axis ticksleftover-map axis {k} tick {value} σ {singular}(ADR 0327), from leftover-map graphic leftover-map axisleftover-map axis {k} σ {value} ({share}%)(ADR 0324), from leftover-axisleftover axis {k} {share}%(ADR 0325), from comparison leftover-axisleftover map comparison leftover axis {k} {share}%(ADR 0323), from comparison graphic leftover-map axisleftover map comparison graphic leftover-map axis {k} σ {value} ({share}%)(ADR 0326), from comparison leftover-axis ticksleftover map comparison leftover axis {k} tick {value} σ {singular}(ADR 0329), from leftover-axis ticksleftover axis {k} tick {value} σ {singular}(ADR 0330), and from comparison graphic leftover-map axis ticksleftover map comparison graphic leftover-map axis {k} tick {value} σ {singular}(ADR 0328).leftover map comparison graphic leftover-map axis {k} tick {value}orleftover map comparison graphic leftover-map axis {k} tick {value} σ {singular}. Rank-0 unused axes still name leftover-map axis share0%. Share and singular value omit independently. Do not invent leftover-map axis share fromσ_k. Do not inventσ_kfrom leftover-map axis share.feat/leftover-map-axis-tick-badge-v2870/ feat(reports): leftover-map singular values on leftover-axis ticks independently of leftover-map axis share (v2.87.0) #871 @e9e4c2a). Leave this PR open for independent review. Do not squash-merge onto the unprotected leftover base. Do not self-approve. After independent review, retarget onto leftover-coordinates (feat/leftover-map-coordinates-v2240/ feat(reports): persist leftover-map coordinates (v2.24.0) #782) rather than squash-merging here. Issues Milestone 2: port verified direct-PostgreSQL analysis into the protected product architecture #79 and Milestone 2.1: add normalized runtime-analysis schema bridge after v0.77 #87 stay open. Do not merge revert: undo #782 squash until independent APPROVE #808 without independent APPROVE.Test plan
leftoverMapPlotAxisSingular.test.tsleftoverMapComparePlotTickAxisBadge names 82%/18% with σ 1.84/0.86, share-only when σ omits, rank-0 share 0%, omits NaN/null share independently of σ, does not invent share from σ or σ from share, leftoverMapPlotTickAxisBadge stays σ-onlyLeftoverMapPlot.test.tsxcomparison ticks with share presenttick +0.50 σ 1.84 82%/tick −0.02 σ 0.86 18%/ rank-0tick 0.00 σ 0.00 0%; σ-omitted+share-present share-onlytick +0.50 82%; NaN-share still σ-only; graphic ticks stay σ-onlyApp.test.tsxgrouping comparison tickleftover map comparison graphic leftover-map axis 1 tick +0.50 σ 1.84 82%i18n.test.tsko/zh/ja/vi share and singular-share tick keystsc -b+ vitest leftover-map + App (659 passed)