feat(reports): leftover-map singular values on leftover-map graphic leftover-map axis ticks independently of leftover-map axis share (v2.84.0) - #868
Conversation
…eftover-map axis ticks independently of leftover-map axis share (v2.84.0)
Caption leftover-map graphic leftover-map axis ticks with persisted leftover-map singular values σ_k through leftoverMapPlotTickAxisBadge independently of leftover-map axis share (ADR 0327). Tick copy stays leftover-map axis {k} tick {value} σ {singular} when σ_k is finite so it stays distinct from leftover-map axis {k} σ {value}, leftover axis {k} σ {value}, leftover map comparison leftover axis {k} σ {value}, leftover map comparison graphic leftover-map axis {k} σ {value}, and leftover map comparison graphic leftover-map axis {k} tick {value}. Rank-0 unused axes still name σ 0.00. Singular value omits independently of leftover-map axis share. Leftover-map graphic leftover-map axis ticks never name leftover-map axis share. Do not invent σ_k from leftover-map axis share. Never invent a leftover score. Never invent a theta.
|
Cycle 2026-08-31 12:23 KST. Writes work as seonghobae. Exact head |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Cycle 2026-08-31 12:23 KST. Writes work. Exact head Next buyer increment after this stacked σ_k surface: leftover-map comparison graphic leftover-map axis ticks naming persisted σ_k independently of leftover-map axis share (named helper leftoverMapComparePlotTickAxisBadge matching leftoverMapPlotTickAxisBadge / leftoverMapComparePlotAxisBadge / leftoverMapPlotAxisBadge / leftoverMapCompareAxisBadge / leftoverMapAxisBadge), or the next already-persisted leftover-map quantity that still has no buyer caption. Do not persist leftover-map inner product, cosine, or length. Synthetic fixtures only. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| if (variant === "comparison") { | ||
| return tf(LEFTOVER_MAP_COMPARE_PLOT_TICK, { axis: axisIndex, value: tickLabel }); | ||
| } | ||
| const leftoverSingular = leftoverSingularForAxis(leftoverMapAxes, axisIndex); | ||
| const badge = leftoverMapPlotTickAxisBadge(axisIndex, tickLabel, leftoverSingular); | ||
| return tf(badge.key, badge.values); |
There was a problem hiding this comment.
📝 Info: Comparison labels remain isolated
The comparison branch returns before singular-value lookup. Shared rendering therefore cannot leak the new report caption into comparison ticks.
Was this helpful? React with 👍 or 👎 to provide feedback.
| export function leftoverMapPlotTickAxisBadge( | ||
| axisIndex: number, | ||
| tickLabel: string, | ||
| leftoverSingular: number | null | undefined, | ||
| ): LeftoverMapCompareAxisBadge { | ||
| const singular = formatLeftoverMapPlotAxisSingular(leftoverSingular); | ||
| if (singular === null) { | ||
| return { key: LEFTOVER_MAP_PLOT_TICK, values: { axis: axisIndex, value: tickLabel } }; | ||
| } | ||
| return { | ||
| key: LEFTOVER_MAP_PLOT_TICK_SINGULAR, | ||
| values: { axis: axisIndex, value: tickLabel, singular }, | ||
| }; | ||
| } |
There was a problem hiding this comment.
📝 Info: Malformed singular values fail closed
formatLeftoverMapPlotAxisSingular rejects missing, negative, and non-finite values while preserving zero. The fallback retains the original tick caption.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
Independent review still required on exact head Next buyer increment stacked locally: leftover-map comparison graphic leftover-map axis ticks with persisted leftover-map singular values |
|
Stacked follow-on opened: #869 leftover-map comparison graphic leftover-map axis ticks with persisted leftover-map singular values |
seonghobae
added
enhancement
ChatGPT Codex Connector
1 participant
Summary
σ_kthrough leftoverMapPlotTickAxisBadge independently of leftover-map axis share (ADR 0327 / v2.84.0).make seed, leftover-map graphic leftover-map axis ticks name persisted leftover-map singular values when leftoverMapPlotTickAxisBadge returns a usable leftover-map axis tickσcaption even when leftover-map axis share is omitted; click a leftover pair opens that post.leftover-map axis {k} tick {value} σ {singular}whenσ_kis finite so they stay distinct from leftover-map graphic leftover-map axisleftover-map axis {k} σ {value}(ADR 0324), from leftover-axisleftover axis {k} σ {value}(ADR 0325), from comparison leftover-axisleftover map comparison leftover axis {k} σ {value}(ADR 0323), from comparison graphic leftover-map axisleftover map comparison graphic leftover-map axis {k} σ {value}(ADR 0326), and from comparison graphic leftover-map axis ticksleftover map comparison graphic leftover-map axis {k} tick {value}(ADR 0320).σtick caption and keepsleftover-map axis {k} tick {value}. Rank-0 unused axes still nameσ 0.00. Leftover-map graphic leftover-map axis ticks never name leftover-map axis share. Do not inventσ_kfrom leftover-map axis share. Do not invent leftover-map axis share fromσ_k.feat/leftover-map-compare-plot-axis-badge-v2830/ feat(reports): leftover-map comparison graphic leftover-map axis leftover-map singular values as leftoverMapComparePlotAxisBadge (v2.83.0) #867 @cf7bb55). Leave this PR open for independent review. Do not squash-merge onto the unprotected leftover base. Do not self-approve. After independent review, retarget onto leftover-coordinates (feat/leftover-map-coordinates-v2240/ feat(reports): persist leftover-map coordinates (v2.24.0) #782) rather than squash-merging here. Issues Milestone 2: port verified direct-PostgreSQL analysis into the protected product architecture #79 and Milestone 2.1: add normalized runtime-analysis schema bridge after v0.77 #87 stay open. Do not merge revert: undo #782 squash until independent APPROVE #808 without independent APPROVE.Test plan
leftoverMapPlotAxisSingular.test.tsleftoverMapPlotTickAxisBadge reads 1.84/0.86 on +0.50/−0.02, names rank-0 0, omit NaN/Infinity/null/negative independently of share, σ copyleftover-map axis {axis} tick {value} σ {singular}, never names leftover-map axis share, do not invent σ from leftover-map axis share or share from σ, stay distinct from leftoverMapPlotAxisBadge / leftoverMapComparePlotAxisBadge / leftoverMapCompareAxisBadge / leftoverMapAxisBadgeLeftoverMapPlot.test.tsxleftover-map graphic leftover-map axis 1 tick +0.50 σ 1.84 / leftover-map axis 2 tick −0.02 σ 0.86; rank-0 leftover-map axis 1 tick 0.00 σ 0.00; σ-only leftover-map axis 1 tick +0.50 σ 1.84 when share is omitted; comparison graphic ticks stay leftover map comparison graphic leftover-map axis 1 tick +0.50i18n.test.tsrequired keys for leftover-map graphic leftover-map axis tick σ in ko/zh/ja/vi (잔여 지도 축 1 눈금 +0.50 σ 1.84/残差图轴 1 刻度 +0.50 σ 1.84/残差マップ軸 1 目盛 +0.50 σ 1.84/vạch trục bản đồ phần dư 1 +0.50 σ 1.84)make seed, leftover-map graphic leftover-map axis ticks name leftover-map singular values even when leftover-map axis share is omitted; click opens that post.Evidence boundary
Authenticated PostgreSQL API and k6 runtime acceptance are not claimed. No real records or credentials. Synthetic fixtures only.
Independent approval is required. No self-approval, admin bypass, or force push.
Jeon, M., Jin, I. H., Schweinberger, M., & Baugh, S. (2021). Mapping unobserved item–respondent interactions: A latent space item response model with interaction map. Psychometrika, 86(2), 378–403.
Gabriel, K. R. (1971). The biplot graphic display of matrices with application to principal component analysis. Biometrika, 58(3), 453–467.