-
Notifications
You must be signed in to change notification settings - Fork 1
feat(reports): preserve grouping-comparison coordinate-payload delta for serialized successor #840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
seonghobae
wants to merge
2
commits into
feat/leftover-map-compare-coordinates-v2590
Choose a base branch
from
feat/leftover-map-compare-coordinates-payload-v2600
base: feat/leftover-map-compare-coordinates-v2590
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
CHANGELOG.d/2.60.0-leftover-map-compare-coordinates-payload.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| ## 2.60.0 — Leftover-map coordinates on grouping comparison leftover-pair payload | ||
|
|
||
| - Return persisted leftover-map coordinates `ξ` / `ζ` on | ||
| `GET /api/reports/compare/{period}` leftover pairs (ADR 0303). After | ||
| `make seed`, grouping comparison leftover-pair buttons that already | ||
| caption formatLeftoverMapCoordinates can match leftover-map coordinates | ||
| on the pair row from the live compare payload; click a post marker or a | ||
| pair button opens that post. A missing axis stays null and omits that | ||
| leftover-map comparison coordinates badge independently of leftover-map | ||
| rank, leftover expected `E`, leftover observed `Y`, leftover residual `R`, | ||
| leftover-map unexplained leftover `U`, leftover-map cross share `x`, | ||
| leftover-map unexplained leftover share `s`, leftover-map explained leftover | ||
| share `e`, leftover-map reconstruction `R̂`, leftover-map distance `d`, and | ||
| the strip coverage notes. Rank-0 origin cells still return `0.0` on each | ||
| axis when those persisted coordinates are stored. Do not invent coordinates | ||
| from leftover-map rank, leftover-map distance, or leftover-map reconstruction. | ||
| A finite negative leftover is shown, never clamped. The strip does not gain | ||
| the leftover-map graphic. Never invent a leftover score. Never invent a | ||
| theta. No new columns. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1052,7 +1052,9 @@ async def fetch_period_comparison( | |
| f""" | ||
| select lp.grouping_kind, lp.grouping_key, lp.pair_kind, lp.post_id, | ||
| lp.criterion_code, lp.leftover_distance, lp.leftover_residual, | ||
| lp.leftover_map_reconstruction, | ||
| lp.leftover_map_reconstruction, lp.leftover_map_person_axis_1, | ||
| lp.leftover_map_person_axis_2, lp.leftover_map_item_axis_1, | ||
| lp.leftover_map_item_axis_2, | ||
| p.post_title, p.visibility_code, p.corporate_entity_id, | ||
| ({_SOURCE_CONTEXT_PRESENT_SQL}) as has_real_source_context | ||
| from report_leftover_pair lp | ||
|
|
@@ -1123,6 +1125,26 @@ async def fetch_period_comparison( | |
| if pair["leftover_map_reconstruction"] is None | ||
| else float(pair["leftover_map_reconstruction"]) | ||
| ), | ||
| "leftover_map_person_axis_1": ( | ||
| None | ||
| if pair["leftover_map_person_axis_1"] is None | ||
| else float(pair["leftover_map_person_axis_1"]) | ||
| ), | ||
| "leftover_map_person_axis_2": ( | ||
| None | ||
| if pair["leftover_map_person_axis_2"] is None | ||
| else float(pair["leftover_map_person_axis_2"]) | ||
| ), | ||
| "leftover_map_item_axis_1": ( | ||
| None | ||
| if pair["leftover_map_item_axis_1"] is None | ||
| else float(pair["leftover_map_item_axis_1"]) | ||
| ), | ||
| "leftover_map_item_axis_2": ( | ||
| None | ||
| if pair["leftover_map_item_axis_2"] is None | ||
| else float(pair["leftover_map_item_axis_2"]) | ||
| ), | ||
|
Comment on lines
+1128
to
+1147
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Comment on lines
+1128
to
+1147
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| "visibility_code": pair["visibility_code"], | ||
| "corporate_entity_id": str(pair["corporate_entity_id"]), | ||
| "has_real_source_context": bool(pair["has_real_source_context"]), | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Non-finite coordinates break comparisons
When a stored coordinate is
NaNor infinite,floatforwards it into JSON. The entire comparison request fails instead of omitting coordinates.Prompt for agents
Was this helpful? React with 👍 or 👎 to provide feedback.