-
Notifications
You must be signed in to change notification settings - Fork 1
feat(reports): preserve grouping comparison axis-singular delta for serialized successor #830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
seonghobae
wants to merge
12
commits into
feat/leftover-map-compare-unexplained-share-v2520
Choose a base branch
from
feat/leftover-map-compare-axis-singular-v2510
base: feat/leftover-map-compare-unexplained-share-v2520
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
ef5fcf6
feat(reports): leftover-map singular values on grouping comparison st…
seonghobae c6f9654
feat(reports): reconstruct grouping comparison axis singular value on…
aa54b5e
test(reports): require current axis-singular release authority
seonghobae 8f6e17c
docs(reports): allocate ADR 0370 and v2.56.0
seonghobae 5e7756b
test(reports): bind axis-singular release to universal lock
seonghobae 704bd36
ci(release): regenerate v2.56 universal lock once
seonghobae 9b06dce
chore(release): regenerate v2.56 universal lock [lock-regenerated]
github-actions[bot] fe48037
ci(release): remove completed v2.56 lock regeneration workflow
seonghobae 63a7f95
test(reports): cover large finite axis singular formatting
seonghobae 09a3a8f
fix(reports): keep large axis singular values fixed-decimal
seonghobae d4aa190
ci(reports): repair finite-axis assertion once
seonghobae b36b253
test(reports): require finite persisted axis singular values
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # v2.56.0 — grouping-comparison leftover-map axis singular values | ||
|
|
||
| Grouping-comparison rows now surface persisted finite, non-negative leftover-map singular values `σ_k` for Gabriel axes under ADR 0370. Persisted zero remains visible as `0.00`; missing, non-finite, or negative values omit only the singular caption. Axis share and singular availability are independent, and LineageWeave never derives `σ_k` from any UI-visible or psychometric proxy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # ADR 0370 — Persisted leftover-map singular values in grouping comparison axes | ||
|
|
||
| **Decision status:** Proposed | ||
|
|
||
| ## Problem | ||
| The grouping-comparison read model persists `leftover_singular_value` for each Gabriel leftover-map axis, but exact predecessor #829 (`0e4fd5815686120ec66203cb6848834b56bdf289`, ADR 0369 / v2.55.0) does not expose that scale on the comparison strip. Historical #830 demonstrated the buyer-visible delta on stale ancestry and historical ADR 0294 / v2.51.0, which are evidence only because those identities now belong to different serialized decisions. | ||
|
|
||
| ## Constraints | ||
| - Consume only persisted `leftover_singular_value`; LineageWeave must not derive `σ_k` from axis share, pair or marker counts, coordinates, distance, rank, coverage, incomplete counts, reconstruction, or any other psychometric value. | ||
| - Accept only finite, non-negative persisted values. Persisted zero is meaningful and must remain visible as `0.00`; missing, non-finite, or negative values omit only the singular-value caption. | ||
| - Singular-value availability and axis-share availability are independent. An invalid or missing value on one axis metric must not suppress a valid value on the other. | ||
| - Preserve the existing full-visible-grouping authorization boundary for persisted grouping aggregates; do not reconstruct a hidden population from caller-visible members. | ||
| - The comparison caption remains a LineageWeave read-model/UI concern. Psychometric estimation and true-parameter validation remain owned by the released `fast-mlsirm` boundary. | ||
| - The canonical eight-locale translation resource remains the versioned database ledger serialized through #922/#929/#932. This decision must not create a competing inline ES/DE/FR store. | ||
|
|
||
| ## Alternatives and decision | ||
| Omitting `σ_k` hides persisted Gabriel scale that is already available in the authorized read model. Recomputing it in the client would duplicate psychometric authority and can diverge from the persisted factorization. Coupling singular display to axis-share validity would also discard valid evidence. Therefore the grouping-comparison strip consumes the persisted scalar directly, formats finite non-negative values independently from axis share, preserves zero, and fail-closes only the invalid singular caption. | ||
|
|
||
| This is the serialized successor of exact #829 and allocates v2.56.0. Historical #830 ADR 0294 / v2.51.0 remains provenance only; current ADR 0294 continues to govern grouping-comparison incomplete-item coverage. | ||
|
|
||
| ## Verification | ||
| A current-parent test must first RED because exact #829 lacks the grouping-comparison singular formatter. The causal implementation then requires focused formatter/render/API regressions, the full PostgreSQL-backed backend suite, frontend lint/test/build/Storybook, release-version parity, and a clean exact-head tree. Material UI completion additionally requires current-head responsive, keyboard, focus, and accessibility evidence. Hosted security gates and qualifying independent review remain separate merge gates; this ADR stays Proposed until the protected-main release is actually accepted. | ||
|
|
||
| ## Evidence | ||
| Gabriel, K. R. (1971). The biplot graphic display of matrices with application to principal component analysis. *Biometrika, 58*(3), 453–467. | ||
|
|
||
| Jeon, M., Jin, I. H., Schweinberger, M., & Baugh, S. (2021). Mapping unobserved item–respondent interactions: A latent space item response model with interaction map. *Psychometrika, 86*(2), 378–403. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -130,4 +130,4 @@ | |
| "serialize_lineage_analysis_result", | ||
| ] | ||
|
|
||
| __version__ = "2.55.0" | ||
| __version__ = "2.56.0" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 changes: 42 additions & 0 deletions
42
tests/test_leftover_map_compare_axis_singular_release_authority.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| """ADR and release-identity regression for grouping-comparison axis singular values.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import json | ||
| import re | ||
| import tomllib | ||
| from pathlib import Path | ||
|
|
||
| _ROOT = Path(__file__).resolve().parents[1] | ||
| _ADR_DIRECTORY = _ROOT / "docs" / "adr" | ||
|
|
||
|
|
||
| def test_axis_singular_decision_uses_unclaimed_proposed_adr_0370() -> None: | ||
| """Keep the reconstructed axis-singular decision off historical ADR 0294.""" | ||
| canonical = _ADR_DIRECTORY / "0370-leftover-map-compare-axis-singular.md" | ||
|
|
||
| assert canonical.exists(), "axis-singular decision must use unclaimed ADR 0370" | ||
| content = canonical.read_text(encoding="utf-8") | ||
| assert content.startswith("# ADR 0370 —") | ||
| assert "**Decision status:** Proposed" in content | ||
| assert "**Decision status:** Accepted" not in content | ||
| assert "v2.56.0" in content | ||
|
|
||
|
|
||
| def test_axis_singular_release_identity_is_2560_everywhere() -> None: | ||
| """Keep the reconstructed feature on one unreleased product identity.""" | ||
| project = tomllib.loads((_ROOT / "pyproject.toml").read_text(encoding="utf-8")) | ||
| frontend = json.loads((_ROOT / "frontend" / "package.json").read_text(encoding="utf-8")) | ||
| runtime = (_ROOT / "lineageweave" / "__init__.py").read_text(encoding="utf-8") | ||
| lock = tomllib.loads((_ROOT / "uv.lock").read_text(encoding="utf-8")) | ||
| locked_lineageweave = [ | ||
| package for package in lock["package"] if package.get("name") == "lineageweave" | ||
| ] | ||
| match = re.search(r'^__version__ = "([^"]+)"$', runtime, flags=re.MULTILINE) | ||
|
|
||
| assert match is not None | ||
| assert project["project"]["version"] == "2.56.0" | ||
| assert frontend["version"] == "2.56.0" | ||
| assert match.group(1) == "2.56.0" | ||
| assert len(locked_lineageweave) == 1 | ||
| assert locked_lineageweave[0]["version"] == "2.56.0" |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.