Skip to content

feat(reports): leftover-map unexplained leftover share on pair segments (v2.31.0) - #803

Closed
seonghobae wants to merge 1 commit into
feat/leftover-map-segment-explained-share-v2300from
feat/leftover-map-segment-unexplained-share-v2310
Closed

feat(reports): leftover-map unexplained leftover share on pair segments (v2.31.0)#803
seonghobae wants to merge 1 commit into
feat/leftover-map-segment-explained-share-v2300from
feat/leftover-map-segment-unexplained-share-v2310

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Superseded by verified full carryover in #811

Closed without merge only under the verified-successor exception. Exact head 089a15713736cbecd4141d460c43d985d3973a92 is the immutable merge base of open successor #811 head e626a1d0770208d6f821e06542091aa2ead87f25; fresh compare is ahead by 6 / behind by 0.

#811 preserves this PR's complete unexplained-share implementation, ADR 0274, changelog/docs, i18n/layout/component source and executable tests/fixtures together with all later segment-caption deltas. #811 is intentionally Draft and currently conflicts with the live #802 foundation after that parent advanced; that conflict is a repair finding and does not remove this immutable carryover.

Review 5120255499 records the carryover. Historical checks/reviews do not transfer. No force-push, squash, destructive rebase, gate weakening, or source deletion was used.

…ts (v2.31.0)

Caption leftover-map graphic-display pair segments with persisted
leftover-map unexplained leftover share s = U²/R² (ADR 0274). After
make seed, closest and farthest leftover pairs sit above the member
list with the Gabriel biplot of already-named coordinates, leftover-map
axis share when finite, axis ticks that match ξ (x, y) ζ (x, y) on the
pair row, pair segments that match d on the pair row, pair segments
that match R̂ on the pair row, pair segments that match R̂²/R² on the
pair row, and pair segments that match U²/R² on the pair row; click a
post marker or a pair button opens that post. A missing or non-finite
s omits that unexplained leftover share caption. A share greater than 1
is shown, never clamped. Do not invent s from U and R or from plotted
coordinates. Never invent a leftover score or a theta. No new columns.

Copy link
Copy Markdown
Contributor Author

Write probe after open. Stacked onto leftover-map explained leftover share (feat/leftover-map-segment-explained-share-v2300 / #802). Independent APPROVE required. Copilot review is not independent APPROVE. Do not self-approve. Do not squash-merge this PR onto the leftover base. After independent review, retarget onto leftover-coordinates (#782) rather than landing on unprotected leftover-map explained leftover share.

@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c654ed1f-e926-4d0e-9ede-bcf8303e6b23

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Copy link
Copy Markdown
Contributor Author

Cycle 2026-08-29: independent APPROVE still required on exact head 089a157. No self-approval. #804 leftover-map cross share x on pair segments (v2.32.0 / ADR 0275) is stacked on this PR. Do not squash-merge onto the leftover base.

@opencode-agent

Copy link
Copy Markdown
Contributor

Scheduled review-feedback autofix for this PR head.

  • Head SHA: 089a15713736cbecd4141d460c43d985d3973a92

@opencode-agent

Copy link
Copy Markdown
Contributor

Scheduled review-feedback autofix for this PR head.

  • Head SHA: 089a15713736cbecd4141d460c43d985d3973a92

@opencode-agent

Copy link
Copy Markdown
Contributor

Scheduled review-feedback autofix for this PR head.

  • Head SHA: 089a15713736cbecd4141d460c43d985d3973a92

@opencode-agent

opencode-agent Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Scheduled review-feedback autofix for this PR head.

  • Head SHA: 089a15713736cbecd4141d460c43d985d3973a92

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified-successor carryover: #811 exact head e626a1d0770208d6f821e06542091aa2ead87f25 contains this exact head as its merge base and is 6 commits ahead / 0 behind. #811 is now the Draft successor retargeted to live #802; its current merge conflict is an explicit repair finding, not loss of this PR's delta. The immutable #811 head preserves this PR's complete unexplained-share implementation, ADR 0274, changelog/docs, i18n/layout/component source and executable tests/fixtures. Historical checks/reviews do not transfer. Closing #803 is therefore valid only under complete successor carryover.

@seonghobae seonghobae closed this Sep 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant