Skip to content

feat(client): add offline semantic release admission contract - #5

Draft
seonghobae wants to merge 80 commits into
feat/foundation-architecturefrom
feat/semantic-release-client
Draft

feat(client): add offline semantic release admission contract#5
seonghobae wants to merge 80 commits into
feat/foundation-architecturefrom
feat/semantic-release-client

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Purpose

Advance Issue #3 through the Rust-first, provider-independent Client Consumption bounded context. Downstream products consume governed immutable semantic_release contracts without importing generator internals, provider payloads, persistence tables, or orchestration state.

Current exact stack — 2026-09-05

  • Foundation prerequisite: feat: establish ConceptWeave foundation #1 b538470c963e6524ddc0c3f652a46a4fc8265150;
  • exact Client head: fcf36c8a99f015b963c9f812787df127ac2e2f9e;
  • Draft/open/mergeable;
  • this is a non-force two-parent successor: old Client head is retained as first parent and current Foundation as second parent. The Client semantic-release/supersession tree is preserved while the refreshed gap baseline is adopted;
  • predecessor/local evidence does not transfer; current protected exact-head GREEN is not claimed.

Current contract

The source retains a versioned public semantic-release schema, owned 100% coverage enforcement, structural plus deterministic semantic supersession validation, immutable-content collision rejection in SemanticReleaseClient::diff, and explicit predecessor/successor lifecycle handling. Client Consumption owns generic release admission, integrity, compatibility, diff, resolution and supersession validation; consuming products retain tenant/purpose authorization, business truth and physical execution.

semantic-data-portal remains catalog/governance/consumption, context-graph-contracts interop, enterprise-architecture-core EA, and contextual-orchestrator production LLM/provider routing. These deterministic validators make no model call.

Merge gate

Keep Draft until Foundation is independently integrated and this exact successor has terminal Product/security/SAST/dependency/review evidence plus zero valid unresolved findings. No self-approval, routine admin bypass, fail-open scanner substitution, force-push, destructive rebase, mutable supplier dependency, or predecessor-evidence transfer.

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Reserve ADR 0004 for Source Observation and move the Client boundary to ADR 0005. Deduplicate LLVM source regions across integration-test binaries and restore the documented detached-artifact contract.

Signed-off-by: Seongho Bae <me@seonghobae.me>
@seonghobae

Copy link
Copy Markdown
Contributor Author

Current-head repair 61776fbf5969ec4f8897f48b7bd410052f83ea9d removes the stacked ADR collision by reserving ADR 0004 for Source Observation and renumbering the Client boundary to ADR 0005. It also repairs the real local Product RED: Gap traceability now names verify_detached_artifact, and coverage deduplicates production source regions across integration-test binaries just as branch coverage already did. Fresh local Rust 1.98 fmt, Clippy, all workspace tests, CI-contract validation, and source-coordinate line/function/region/branch coverage all pass at 100%. The PR remains Draft; hosted checks on this exact head are new evidence and predecessor results do not transfer.

@seonghobae
seonghobae marked this pull request as ready for review September 4, 2026 14:24
@seonghobae

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-04T14:49:43.788489Z 0087f6c Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@seonghobae
seonghobae marked this pull request as draft September 4, 2026 14:28

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0087f6c8bd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread contracts/semantic-release-supersession.schema.json
Comment thread crates/conceptweave-client/src/lib.rs
Comment thread contracts/semantic-release.schema.json Outdated
@seonghobae
seonghobae marked this pull request as ready for review September 4, 2026 14:40
@seonghobae
seonghobae marked this pull request as draft September 4, 2026 14:41

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0087f6c8bd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/check_coverage.sh Outdated
Comment thread crates/conceptweave-client/src/lib.rs Outdated
seonghobae added a commit that referenced this pull request Sep 4, 2026
# Conflicts:
#	ARCHITECTURE.md
#	CHANGELOG.md
#	Cargo.lock
#	Cargo.toml
#	docs/PRD.md
#	docs/TRD.md
#	docs/adr/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant