fix: retry Strix provider tool protocol failures #933
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # Strix tool-protocol fallback | ||
|
|
||
| ## Incident and buyer impact | ||
|
|
||
| Strix can exit before producing security evidence when the selected model | ||
| emits a tool call the `strix` agent does not expose: | ||
|
|
||
| `agents.exceptions.ModelBehaviorError: Tool execute not found in agent strix` | ||
|
|
||
| The required check then failed as if the target repository were insecure, | ||
| and configured fallback models never ran. | ||
|
|
||
| ## Decision | ||
|
|
||
| Classify only that exact exception class, missing-tool phrase, and agent | ||
| name `strix` as retryable infrastructure. Fallback to a distinct configured | ||
| model. Vulnerability artifacts and fallback exhaustion remain fail-closed. | ||
| Generic application errors are not matched. | ||
|
|
||
| ## References | ||
|
|
||
| National Institute of Standards and Technology. (2020). *Security and | ||
| privacy controls for information systems and organizations* (NIST Special | ||
| Publication 800-53 Rev. 5). https://doi.org/10.6028/NIST.SP.800-53r5 | ||
|
|
||
| OpenAI. (2025). *OpenAI Agents SDK*. | ||
| https://openai.github.io/openai-agents-python/ |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3357,6 +3357,15 @@ is_llm_token_limit_error() { | |
| return 1 | ||
| } | ||
|
|
||
| # Strix's agent SDK can reject a provider response before it produces scan | ||
| # evidence when the model emits a tool call that the selected agent does not | ||
| # expose. Treat this exact SDK/provider failure as retryable so a configured | ||
| # fallback model can complete the security scan; it is not evidence from the | ||
| # target repository and must never be treated as a vulnerability. | ||
| is_model_tool_protocol_error() { | ||
| grep -Eiq 'agents\.exceptions\.ModelBehaviorError:[[:space:]]*Tool [[:alnum:]_]+ not found in agent strix' "$STRIX_LOG" | ||
|
Contributor
There was a problem hiding this comment. 📝 Info: Tool name pattern only matches alphanumeric/underscore tool identifiers The tool-name capture in the regex is 
Was this helpful? React with 👍 or 👎 to provide feedback. |
||
| } | ||
|
Comment on lines
+3365
to
+3367
Contributor
There was a problem hiding this comment. 📝 Info: Tool-protocol regex untested for the
Was this helpful? React with 👍 or 👎 to provide feedback.
Comment on lines
+3365
to
+3367
Contributor
There was a problem hiding this comment. 🔍 Tool-protocol classifier does not require a separate provider marker; relies on the SDK exception prefix
Was this helpful? React with 👍 or 👎 to provide feedback. |
||
|
|
||
| # Detect whether the strix log contains evidence of infrastructure-level | ||
| # errors (timeout, rate-limit, transport failures) that indicate the scan | ||
| # was interrupted or incomplete. Used as a guard to prevent the | ||
|
|
@@ -3378,6 +3387,10 @@ has_detected_infrastructure_error() { | |
| return 0 | ||
| fi | ||
|
|
||
| if is_model_tool_protocol_error; then | ||
| return 0 | ||
| fi | ||
|
|
||
| if is_midstream_fallback_error; then | ||
| return 0 | ||
| fi | ||
|
|
@@ -4268,6 +4281,12 @@ is_model_retryable_error() { | |
| return 0 | ||
| fi | ||
|
|
||
| if is_model_tool_protocol_error; then | ||
| # A provider/model tool-contract failure is recoverable with a distinct | ||
| # configured model, but it is not a clean scan result. | ||
| return 0 | ||
| fi | ||
|
Comment on lines
+4284
to
+4288
Contributor
There was a problem hiding this comment. 📝 Info: Tool-protocol errors correctly skip same-model retry and go straight to fallback The new error class is intentionally absent from
Was this helpful? React with 👍 or 👎 to provide feedback. |
||
|
|
||
| if is_timeout_error; then | ||
| # Process and provider timeouts are not clean evidence, but they are | ||
| # recoverable across distinct fallback models. Strict provider-signal | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 ARCHITECTURE.md introduces two blank lines inside a bulleted list
The diff inserts two blank lines (ARCHITECTURE.md) between two adjacent list items in the 'Related durable documents' section, which splits what was a single markdown list. Cosmetic only, but the author's description states these unrelated doc changes (AGENTS.md/CLAUDE.md/ARCHITECTURE.md) were meant to be removed from this lane's scope — worth confirming whether they should be present in the PR at all.
Was this helpful? React with 👍 or 👎 to provide feedback.