Repository navigation
fix(codeql): direct SARIF publication with fsync custody (activation HOLD) - #2666
Draft
seonghobae wants to merge 1 commit into
Draft
seonghobae wants to merge 1 commit into
seonghobae wants to merge 1 commit into
Conversation
Publish exact independently reviewed source only. R1 fsync namespace repair is included. Original-byte survival, backup, seven-day retention and target security-events write capability remain operational HOLD. No activation. AI-assisted-by: Hermes Agent (Nous Research)
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeQL direct-SARIF publication — source only / operational HOLD
Publication boundary
This Draft publishes the independently assessed source only. Do not mark Ready, merge, enable auto-merge, dispatch/rerun CodeQL, or activate this handler while the operational holds below remain. Parent remains the sole S1 executor. Source publicity in this central public repository is authorized; no credentials, installed App grants, runner configuration, retention policy, artifact deletion, protection, or deployment is changed by this publication.
The modified workflow remains subscribed only to
repository_dispatch(codeql-scan/codeql-scan-v2) and executes from the protected default branch. This feature-branch push does not match a native push trigger. Draft is intentional: the existingcodeql-pr.ymldraft guard skips language detection and its dispatch coordinator, Strix and merge-scheduler opened-event jobs are draft guarded, and OpenCode checks live Draft before requesting review dispatch. Noema skips model/sidecar preparation on its live-Draft gate. Existing metadata/bootstrap/coverage jobs may materialize; this is not a zero-jobs claim. No manual workflow dispatch or reviewer request is part of this publication.A later protected adoption of this workflow would make it available to subsequent ordinary repository_dispatch events across consumers. A source merge is therefore not an operationally inert transition: retain the activation hold until the existing custody and capability owners admit it, or independently review a default-off activation fence first.
Exact source custody
6a03ae990eb4769869f4f77970cc21ed35141e097bc2f507889a3f523c3df31ace13614792ae7d2c46fd2145f28960ce8e9995271818f52e057b626dc329e66007fd0ddfa978eb05f2f8f61deeb5334baf2db3b50e06f1467c76c5c59859ee5e539ae0b4460efc6180a3f803d67cb49f83596c7d1bad57a65523a8377bac0a40a93d3f72cb40a51abf070e977c5526282c0f0748ae4c26b5f406a164a9c6d8455b72c98e2cd6b3a1b176eb0b225080f53b5a5dfeb05993abd3b09bddAll 831 leaf paths/modes/bytes and the portable source archive were checked against native Git. Applying the sealed five-path patch to the exact base reconstructed the stated tree. The committed tree, not a dirty index, is the publication payload. No source adaptation or test replay was needed: fresh protected main is still the original base.
Repair and verified scope
CreateArtifactSARIF transport with the supported target code-scanning SARIF API; keep original/upload/processed evidence distinct, one POST, no ambiguous-ACK replay, complete processing and exact upload-associated analysis readback.Retained actual local evidence, read back against exact source/log/JUnit/exit receipts:
The overlapping cohorts total 493 unique green identities / 603 executions, not 603 unique cases. The independent delta reviewer freshly exercised only the bounded 27 identities on predecessor/successor plus collection and coverage-data readback; the complete 436/86 cohorts were not relabeled as fresh. No real runner, real SARIF POST, S1, power-loss/crash simulation, or hosted CI acceptance is claimed by these receipts.
Source-owner reconciliation
Fresh all-436-open-PR inventories, including every paginated file tail, found no existing addition of this helper/test/runbook. Historical shared CodeQL paths remain owned by their existing lanes. In particular #2657 remains OPEN at
e04587abd3cdd228651bf8b64d71a5efd6f29efc; its live-base-ref repair and owner are not superseded, edited, merged, or absorbed here.Native composition of this exact candidate with #2657 is conflict free at tree
b7eb0382b35d896004b4fff3d3cf5f63cf3f7a00. Reversing only this sealed candidate patch recovers #2657's entire tree exactly. This is source composition evidence only; union tests were NOT_RUN and peer adoption is not claimed. Any later adoption must re-fence main and #2657 and execute newly invalidated composition controls through the existing owner.Operational gates — HOLD, not present
security-events: writeApp/installation capability, distinct from analysis-read, status and lifecycle tokens. It is not established by this source or a successful read.analysis-0.jsonintegrity-scope observation remains: do not claim all-file metadata hashing.Exact next normal-adoption action: parent/source owner first keeps this Draft and resolves the assigned-host custody/backup/seven-day and target-write capability holds (or obtains a separately independently reviewed default-off activation fence). Then re-fetch current main and #2657, reconcile only changed source/composition inputs, and use the normal exact-head review/check/Ready/protected-adoption route without bypass or force. Ready can itself start existing CodeQL dispatch; only the parent may release that execution. Publication is not approval, protected shipment, or operational activation.
Refs #2657. No issue is closed by this source-only PR.