Repository navigation
fix(queue-health): preserve runner routing observations - #2655
seonghobae wants to merge 1 commit into
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 22 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
OpenCode reviewed the current-head product diff. Coverage is a separate gate.
Changed files
docs/doctoring/runner-routing-observation-20261015.md— operator or user guidancescripts/ci/actions_queue_health_core.py— review and security gate shell pathtests/test_actions_queue_health_runner_routing.py— regression suite
Changed behavior
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Docs: runner-routing-observation-20261015.md"]
S1 --> I1["operator or user guidance"]
I1 --> R1["Review risk: Docs: runner-routing-observation-20261015.md"]
R1 --> V1["docs review"]
Evidence --> S2["CI script: actions_queue_health_core.py"]
S2 --> I2["review and security gate shell path"]
I2 --> R2["Review risk: CI script: actions_queue_health_core.py"]
R2 --> V2["bash -n plus Strix self-test"]
Evidence --> S3["Test: test_actions_queue_health_runner_routing.py"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test: test_actions_queue_health_runner_routing.py"]
R3 --> V3["targeted test run"]
Findings
No source-backed product finding is synthesized from the coverage gate. A coverage miss belongs in the status comment.
- Head SHA:
d0e18e08be6e8636a2fba2ef1a99f80d032d6708 - Workflow run: 38726945904
- Workflow attempt: 1
- Coverage gate:
failure
Review outcome
Coverage is a gate, not the review. This body reviews the changed product files.
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Docs: runner-routing-observation-20261015.md"]
S1 --> I1["operator or user guidance"]
I1 --> R1["Review risk: Docs: runner-routing-observation-20261015.md"]
R1 --> V1["docs review"]
Evidence --> S2["CI script: actions_queue_health_core.py"]
S2 --> I2["review and security gate shell path"]
I2 --> R2["Review risk: CI script: actions_queue_health_core.py"]
R2 --> V2["bash -n plus Strix self-test"]
Evidence --> S3["Test: test_actions_queue_health_runner_routing.py"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test: test_actions_queue_health_runner_routing.py"]
R3 --> V3["targeted test run"]
OpenCode Review Overview
Coverage evidence did not pass, so approval is blocked. The formal pull-request review is the source-backed diff review, not this status comment. |
Scope
Preserve optional REST job labels and assigned runner-group metadata through snapshot normalization and JSON reporting. Reject malformed field types and keep missing/null observations separate from explicit empty values. Remove the blanket GitHub-hosted assumption from the queue SLO diagnostic.
This is a three-file diagnostic repair. It does not activate runners, alter workflows, change credentials or permissions, attest isolation, or complete the hosted-to-self-hosted migration. Assigned group metadata does not prove requested-group existence or available capacity. Existing identity, approval, assignment and blocker decisions are unchanged. HTML rendering is unchanged.
Verification
Complete local functional suite: 6539 passed, 10 skipped, 92 subtests passed in 207.64 seconds, exit 0, on Python 3.12 with GITHUB_ACTIONS=true, full Git history and a writable temporary HOME. All three published blob SHAs match the tested local files. This verifies functional tests, not remote coverage or security acceptance.
Ready for normal independent review. Required Actions checks, formal independent approval and protected integration remain pending. Source publication is not operational migration completion. No existing PR branch was modified.