Skip to content

fix(queue-health): preserve runner routing observations - #2655

Open
seonghobae wants to merge 1 commit into
mainfrom
fix/queue-runner-routing-evidence-20261015
Open

seonghobae wants to merge 1 commit into
mainfrom
fix/queue-runner-routing-evidence-20261015

Conversation

@seonghobae

@seonghobae seonghobae commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Scope

Preserve optional REST job labels and assigned runner-group metadata through snapshot normalization and JSON reporting. Reject malformed field types and keep missing/null observations separate from explicit empty values. Remove the blanket GitHub-hosted assumption from the queue SLO diagnostic.

This is a three-file diagnostic repair. It does not activate runners, alter workflows, change credentials or permissions, attest isolation, or complete the hosted-to-self-hosted migration. Assigned group metadata does not prove requested-group existence or available capacity. Existing identity, approval, assignment and blocker decisions are unchanged. HTML rendering is unchanged.

Verification

  • Base: 6a03ae9
  • Head: d0e18e0
  • Initial regression RED: 11 expected failures on unchanged production source.
  • Final queue-health selection: 98 passed normally and 98 passed with GITHUB_ACTIONS=true on Python 3.12.
  • Collector → serialized snapshot → report regression included.
  • Compileall and diff whitespace checks passed.
  • Independent source review found no blocking findings in the normalization repair; its suggested collection-wiring regression was then added and passed.

Complete local functional suite: 6539 passed, 10 skipped, 92 subtests passed in 207.64 seconds, exit 0, on Python 3.12 with GITHUB_ACTIONS=true, full Git history and a writable temporary HOME. All three published blob SHAs match the tested local files. This verifies functional tests, not remote coverage or security acceptance.

Ready for normal independent review. Required Actions checks, formal independent approval and protected integration remain pending. Source publication is not operational migration completion. No existing PR branch was modified.

@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 22 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 72855e53-41b1-4dd1-8714-decf0ff9cccd
📥 Commits

Reviewing files that changed from the base of the PR and between 6a03ae9 and d0e18e0.

📒 Files selected for processing: 3
  • docs/doctoring/runner-routing-observation-20261015.md
  • scripts/ci/actions_queue_health_core.py
  • tests/test_actions_queue_health_runner_routing.py
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review October 15, 2026 11:21

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode reviewed the current-head product diff. Coverage is a separate gate.

Changed files

  • docs/doctoring/runner-routing-observation-20261015.md — operator or user guidance
  • scripts/ci/actions_queue_health_core.py — review and security gate shell path
  • tests/test_actions_queue_health_runner_routing.py — regression suite

Changed behavior

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Docs: runner-routing-observation-20261015.md"]
  S1 --> I1["operator or user guidance"]
  I1 --> R1["Review risk: Docs: runner-routing-observation-20261015.md"]
  R1 --> V1["docs review"]
  Evidence --> S2["CI script: actions_queue_health_core.py"]
  S2 --> I2["review and security gate shell path"]
  I2 --> R2["Review risk: CI script: actions_queue_health_core.py"]
  R2 --> V2["bash -n plus Strix self-test"]
  Evidence --> S3["Test: test_actions_queue_health_runner_routing.py"]
  S3 --> I3["regression suite"]
  I3 --> R3["Review risk: Test: test_actions_queue_health_runner_routing.py"]
  R3 --> V3["targeted test run"]
Loading

Findings

No source-backed product finding is synthesized from the coverage gate. A coverage miss belongs in the status comment.

  • Head SHA: d0e18e08be6e8636a2fba2ef1a99f80d032d6708
  • Workflow run: 38726945904
  • Workflow attempt: 1
  • Coverage gate: failure

Review outcome

Coverage is a gate, not the review. This body reviews the changed product files.

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Docs: runner-routing-observation-20261015.md"]
  S1 --> I1["operator or user guidance"]
  I1 --> R1["Review risk: Docs: runner-routing-observation-20261015.md"]
  R1 --> V1["docs review"]
  Evidence --> S2["CI script: actions_queue_health_core.py"]
  S2 --> I2["review and security gate shell path"]
  I2 --> R2["Review risk: CI script: actions_queue_health_core.py"]
  R2 --> V2["bash -n plus Strix self-test"]
  Evidence --> S3["Test: test_actions_queue_health_runner_routing.py"]
  S3 --> I3["regression suite"]
  I3 --> R3["Review risk: Test: test_actions_queue_health_runner_routing.py"]
  R3 --> V3["targeted test run"]
Loading

@opencode-agent

opencode-agent Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

OpenCode Review Overview

Coverage evidence did not pass, so approval is blocked. The formal pull-request review is the source-backed diff review, not this status comment.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant