Skip to content

fix(noema): fail closed on non-boolean repository visibility fallback - #2627

Merged
seonghobae merged 2 commits into
mainfrom
fix/noema-typed-visibility-20261013
Oct 13, 2026
Merged

seonghobae merged 2 commits into
mainfrom
fix/noema-typed-visibility-20261013

Conversation

@seonghobae

@seonghobae seonghobae commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

변경

noema-review.yml의 대상 저장소 visibility 판정에서 .visibility가 없을 때 쓰는 fallback을 .private의 truthiness가 아닌 정확한 Boolean으로 판정합니다.

  • .private == true → private (ZDR 경로)
  • .private == false → public
  • 그 외(누락, null, 문자열 "false", 0, 1, [], {}) → "" → 기존 case에서 fail-closed

수정 전에는 누락·null·0이 public으로, 문자열 "false"가 private으로 분류됐습니다. 비정상 metadata에서 private source가 비ZDR 경로로 갈 수 있는 결함입니다.

#2621 7f5ba4aa의 기존 수리 한 줄과 회귀 hunk만 main에 이식했습니다. #2621의 다른 변경은 포함하지 않습니다.

검증

  • base main 65117620e8b2e74a4bde8d4a06d181f61babce98, head 9b85f32506009ad7624f46b76b959142259a8cdc
  • 회귀 테스트는 실제 workflow step을 bash로 실행합니다(가짜 gh + 실제 jq, 합성 토큰 누출 검사).
  • RED: 수정 전 15개 중 7 failed. GREEN: 관련 4개 모듈 127 passed, 45 subtests, -W error. Ruff, git diff --check exit 0.
  • 독립 source 검토: passed, blocking_findings 없음, publication_allowed=true. 같은 truthiness 패턴은 다른 workflow/script에 남아 있지 않습니다.
  • 미확인: Actions의 gojq(gh --jq) 직접 실행, GH_TOKEN 선택식·재시도 경로, 원격 CI, Noema/OpenCode formal App review.

Refs #2560, #2621.


Devin Review

@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 37 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 39036f5e-6f2a-4404-838a-4149bbc3d617
📥 Commits

Reviewing files that changed from the base of the PR and between a422fa2 and a1bbd6d.

📒 Files selected for processing (2)
  • .github/workflows/noema-review.yml
  • tests/test_noema_orchestrator_workflow_contract.py
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@seonghobae

Copy link
Copy Markdown
Contributor Author

인프라 예외 병합: 사용자 직접 bypass 허용, head a1bbd6d1f5da13a8ef406b56460d13450f7d5053, actual main 2ec9c34622911db2f113766149413861cb9dfead. 독립 검토 patch와 동일하고 head 전체 6113 passed/4 skipped(exit0), 최신 main의 비중첩 K-CSAP 8파일을 보존하는 merge tree cbeb8fa9b65202c8e33327b4ff2ef930a4c94430를 확인했습니다. Noema는 visibility 이전 단계의 custody 입력 누락, OpenCode는 current-head App review 부재입니다. WAIVED_INFRA이며 PASS/APPROVED가 아닙니다. 대기 검사 3개는 NOT_EXECUTED. 최신 target 전체 suite는 별도 미실행. 키/정책/보호 설정은 변경하지 않습니다. 후속 #2560.

@seonghobae
seonghobae merged commit 0a8573d into main Oct 13, 2026
15 of 20 checks passed
@seonghobae
seonghobae deleted the fix/noema-typed-visibility-20261013 branch October 13, 2026 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant