test(noema): reject preflight evidence through linked parents - #2447
seonghobae wants to merge 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 14 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Exact-head admission correction — Ready is review admission only. Fresh audit against base
This PR is moved to Draft/Proposed until the causal owner repair is present on a successor exact head and re-audited. Queued/pending work is neither an additional blocker nor passing evidence. No Close, force push, destructive rebase, manual rerun, synthetic status/approval, merge, auto-merge, or bypass was performed. |
Summary
Add three lines to the existing preflight file-boundary test to reject a valid all-429 report reached through a symbolic-link parent directory. The sample remains a single-link regular file at that assertion, so the parent guard is independently exercised. Runtime behavior and redispatch budgets are unchanged.
Root cause and verification
During issue #712 integration, clean main
23f36cd56fbe245a06e7a9727cb28d9511154645reproduced the missing rejection atnoema_preflight_capacity.py:98, introduced withde5d44959. Its 45 existing tests passed, but the module gate failed at 98.40% statement/branch coverage. The existing fixture already covers leaf symlinks, FIFOs and hardlinks; this adds the missing parent-directory case.On exact head
0ea65996dba3f014ff863b1055cc81096d48984c:45 passed; the module has 91 statements and 34 branches, all covered. This is module-scoped proof, not a claim that the entire main suite passes. The owning issue #712 integration also carries the separate coverage/docstring prerequisite fixes from #2441 and #2443 and is undergoing the full gate.
Related: #712, #2358. Independent current-head review and required checks remain necessary before merge.