docs(doctoring): plan-ceiling owner brief (post-#2252 residual) - #2258
seonghobae wants to merge 23 commits into
Conversation
Summarize post-#2252 residual (34/2090, ~3.2h admit), folding vs coalesce-false, and owner options that raise concurrent-job budget rather than symptom caps. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning Review limit reachedNext included review available in 51 seconds. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…brief Make owner concurrent-job choices (quota / separate pool / arrival hygiene / keep coalesce false / reject kill-switches) visible without scrolling past the snapshot tables. Co-authored-by: Cursor <cursoragent@cursor.com>
…e the consumer root Green step for a8d6261. The 24 specialized cases in test_strix_quick_gate.sh installed the trusted gate/model/binder into $repo_root_dir/scripts/ci and ran ./scripts/ci/strix_quick_gate.sh, so a consumer-root binder lookup could never fail there and masked the #2292 defect. Each case now materializes into $tmp_dir/trusted-source/scripts/ci and runs the gate from that directory with STRIX_REPO_ROOT=$repo_root_dir, which keeps the old repo-root semantics (the gate defaults REPO_ROOT to SCRIPT_DIR/../..). Evidence: - tests/test_strix_trusted_fixture_boundary.py: fails on a8d6261 (CI job 106083294309), passes here. - bash scripts/ci/test_strix_quick_gate.sh on Linux, umask 022: a8d6261 PASS (rc=0, 727s) and this commit PASS (rc=0, 726s). - strix-related pytest (8 files): 242 passed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P5o6j4zfxGPdRaH4Lug8UY
|
Admission correction — exact current head |
|
Run 35633792650 / job 106515710904 audited stale AnyIO 4.14.0 and reported CVE-2026-63374, CVE-2026-64847, and CVE-2026-63349; #2291 carries the canonical 4.14.2 lock repair. Root-cause repair (exact-head preserving, non-force). The failed Python Security evidence was inherited from the stale central base, not introduced by this PR's documentation delta. I ordinary-restacked this branch on current canonical security/CodeQL owner #2291 ( Post-restack evidence:
New exact head: |
|
Concurrent-head re-audit: 새 head는 0-behind·mergeable·미해결 thread 0·활성 CHANGES_REQUESTED 0·terminal workflow failure 0입니다. Checks는 queued/pending이나 review admission blocker가 아니므로 Ready로 복구합니다. 이전 head의 approval/Checks는 병합 근거로 승계하지 않습니다. Current head의 terminal Checks와 qualifying independent approval 전에는 merge하지 않습니다. |
There was a problem hiding this comment.
Pull request overview
OpenCode reviewed the current-head product diff. Coverage is a separate gate.
Changed files
.github/workflows/codeql-scan-dispatch.yml— GitHub Actions review job.github/workflows/opencode-review-dispatch.yml— GitHub Actions review jobCHANGELOG.d/20260920-strix-trusted-binder-runtime-fixture.md— repository behaviorCHANGELOG.md— repository behaviordocs/doctoring/plan-ceiling-owner-brief-20260918.md— operator or user guidancedocs/product-technical-gap-baseline.md— operator or user guidancerequirements-strix-ci-hashes.txt— repository behaviorrequirements-strix-ci.txt— repository behaviorscripts/ci/actions_queue_health.py— review and security gate shell pathscripts/ci/actions_queue_health_core.py— review and security gate shell pathscripts/ci/strix_quick_gate.sh— review and security gate shell pathscripts/ci/test_strix_quick_gate.sh— review and security gate shell pathtests/test_actions_queue_health_cancelled_before_runner.py— regression suitetests/test_actions_queue_health_post_evidence_retry.py— regression suitetests/test_actions_queue_health_snapshot_consistency.py— regression suitetests/test_actions_queue_health_terminal_preexecution.py— regression suitetests/test_codeql_scan_dispatch_ghas_credential_contract.py— regression suitetests/test_noema_document_review_context.py— regression suitetests/test_noema_review_document_boundaries.py— regression suitetests/test_opencode_agent_contract.py— regression suitetests/test_organization_commercial_readiness_loop_receipt_contract.py— regression suitetests/test_pr_review_autofix_nvidia_nim_contract.py— regression suitetests/test_pr_review_merge_scheduler.py— regression suitetests/test_strix_evidence_binder_trusted_path.py— regression suitetests/test_strix_runtime_dependencies.py— regression suitetests/test_strix_trusted_fixture_boundary.py— regression suite
Changed behavior
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow: codeql-scan-dispatch.yml"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow: codeql-scan-dispatch.yml"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["Workflow: opencode-review-dispatch.yml"]
S2 --> I2["GitHub Actions review job"]
I2 --> R2["Review risk: Workflow: opencode-review-dispatch.yml"]
R2 --> V2["actionlint plus required checks"]
Evidence --> S3["Repository file: 20260920-strix-trusted-binder-runtime-fixture.md"]
S3 --> I3["repository behavior"]
I3 --> R3["Review risk: Repository file: 20260920-strix-trusted-binder-runtime-fixture.md"]
R3 --> V3["required checks"]
Evidence --> S4["Repository file: CHANGELOG.md"]
S4 --> I4["repository behavior"]
I4 --> R4["Review risk: Repository file: CHANGELOG.md"]
R4 --> V4["required checks"]
Evidence --> S5["Docs: plan-ceiling-owner-brief-20260918.md (2 files)"]
S5 --> I5["operator or user guidance"]
I5 --> R5["Review risk: Docs: plan-ceiling-owner-brief-20260918.md (2 files)"]
R5 --> V5["docs review"]
Evidence --> S6["Repository file: requirements-strix-ci-hashes.txt"]
S6 --> I6["repository behavior"]
I6 --> R6["Review risk: Repository file: requirements-strix-ci-hashes.txt"]
R6 --> V6["required checks"]
Evidence --> S7["Repository file: requirements-strix-ci.txt"]
S7 --> I7["repository behavior"]
I7 --> R7["Review risk: Repository file: requirements-strix-ci.txt"]
R7 --> V7["required checks"]
Evidence --> S8["CI script: actions_queue_health.py"]
S8 --> I8["review and security gate shell path"]
I8 --> R8["Review risk: CI script: actions_queue_health.py"]
R8 --> V8["bash -n plus Strix self-test"]
Evidence --> S9["CI script: actions_queue_health_core.py"]
S9 --> I9["review and security gate shell path"]
I9 --> R9["Review risk: CI script: actions_queue_health_core.py"]
R9 --> V9["bash -n plus Strix self-test"]
Evidence --> S10["CI script: strix_quick_gate.sh"]
S10 --> I10["review and security gate shell path"]
I10 --> R10["Review risk: CI script: strix_quick_gate.sh"]
R10 --> V10["bash -n plus Strix self-test"]
Evidence --> S11["CI script: test_strix_quick_gate.sh"]
S11 --> I11["review and security gate shell path"]
I11 --> R11["Review risk: CI script: test_strix_quick_gate.sh"]
R11 --> V11["bash -n plus Strix self-test"]
Evidence --> S12["Test: test_actions_queue_health_cancelled_before_runner.py (14 files)"]
S12 --> I12["regression suite"]
I12 --> R12["Review risk: Test: test_actions_queue_health_cancelled_before_runner.py (14 files)"]
R12 --> V12["targeted test run"]
Findings
No source-backed product finding is synthesized from the coverage gate. A coverage miss belongs in the status comment.
- Head SHA:
a45f71804bb7cec4dd1f8c1113fca35e3d8d3ba8 - Workflow run: 36279936656
- Workflow attempt: 1
- Coverage gate:
failure
Review outcome
Coverage is a gate, not the review. This body reviews the changed product files.
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow: codeql-scan-dispatch.yml"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow: codeql-scan-dispatch.yml"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["Workflow: opencode-review-dispatch.yml"]
S2 --> I2["GitHub Actions review job"]
I2 --> R2["Review risk: Workflow: opencode-review-dispatch.yml"]
R2 --> V2["actionlint plus required checks"]
Evidence --> S3["Repository file: 20260920-strix-trusted-binder-runtime-fixture.md"]
S3 --> I3["repository behavior"]
I3 --> R3["Review risk: Repository file: 20260920-strix-trusted-binder-runtime-fixture.md"]
R3 --> V3["required checks"]
Evidence --> S4["Repository file: CHANGELOG.md"]
S4 --> I4["repository behavior"]
I4 --> R4["Review risk: Repository file: CHANGELOG.md"]
R4 --> V4["required checks"]
Evidence --> S5["Docs: plan-ceiling-owner-brief-20260918.md (2 files)"]
S5 --> I5["operator or user guidance"]
I5 --> R5["Review risk: Docs: plan-ceiling-owner-brief-20260918.md (2 files)"]
R5 --> V5["docs review"]
Evidence --> S6["Repository file: requirements-strix-ci-hashes.txt"]
S6 --> I6["repository behavior"]
I6 --> R6["Review risk: Repository file: requirements-strix-ci-hashes.txt"]
R6 --> V6["required checks"]
Evidence --> S7["Repository file: requirements-strix-ci.txt"]
S7 --> I7["repository behavior"]
I7 --> R7["Review risk: Repository file: requirements-strix-ci.txt"]
R7 --> V7["required checks"]
Evidence --> S8["CI script: actions_queue_health.py"]
S8 --> I8["review and security gate shell path"]
I8 --> R8["Review risk: CI script: actions_queue_health.py"]
R8 --> V8["bash -n plus Strix self-test"]
Evidence --> S9["CI script: actions_queue_health_core.py"]
S9 --> I9["review and security gate shell path"]
I9 --> R9["Review risk: CI script: actions_queue_health_core.py"]
R9 --> V9["bash -n plus Strix self-test"]
Evidence --> S10["CI script: strix_quick_gate.sh"]
S10 --> I10["review and security gate shell path"]
I10 --> R10["Review risk: CI script: strix_quick_gate.sh"]
R10 --> V10["bash -n plus Strix self-test"]
Evidence --> S11["CI script: test_strix_quick_gate.sh"]
S11 --> I11["review and security gate shell path"]
I11 --> R11["Review risk: CI script: test_strix_quick_gate.sh"]
R11 --> V11["bash -n plus Strix self-test"]
Evidence --> S12["Test: test_actions_queue_health_cancelled_before_runner.py (14 files)"]
S12 --> I12["regression suite"]
I12 --> R12["Review risk: Test: test_actions_queue_health_cancelled_before_runner.py (14 files)"]
R12 --> V12["targeted test run"]
OpenCode Review Overview
Coverage evidence did not pass, so approval is blocked. The formal pull-request review is the source-backed diff review, not this status comment. |
Keep the Job Analysis trusted-base authority context and the consumer-free evidence binder, and adopt main's single trusted-runtime fixture that also copies the report-scope helper. Changelog and gap baseline keep both records.
Summary
docs/doctoring/plan-ceiling-owner-brief-20260918.md: owner brief for plan concurrent-job headroom after the post-folding remasure in docs(doctoring): Actions queue-wait remasure after #2228–#2244 #2252 (34 in_progress / ~2,090 queued; dispatch first-job admission ~3.2h).OPENCODE_REVIEW_COALESCE_ENABLED.Test plan
Do not flip
OPENCODE_REVIEW_COALESCE_ENABLEDfrom this PR. Do not merge as a coalesce or kill-switch change.Made with Cursor