Skip to content

docs(claude): replace the required-context count with the measured list - #1965

Open
seonghobae wants to merge 1 commit into
mainfrom
docs/required-contexts-list-not-count
Open

docs(claude): replace the required-context count with the measured list#1965
seonghobae wants to merge 1 commit into
mainfrom
docs/required-contexts-list-not-count

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

CLAUDE.md said .github uses "classic branch protection with 14 named required contexts". The live endpoint returns 12.

gh api repos/ContextualWisdomLab/.github/branches/main/protection \
  --jq ".required_status_checks.contexts | length"
12

Measured 2026-09-06: CodeQL compatibility analysis (actions), CodeQL compatibility analysis (python), Detect CodeQL languages, coverage-evidence, dependency-review, noema-review, opencode-review, osv-scan, required-workflow-bootstrap, scan-pr-queue, scorecard, trivy-fs.

This is not "14 became 12"

git log -S "named required contexts" -- CLAUDE.md returns exactly one commit7d093881 (#1766) — and the sentence has never been revised since. Branch-protection edits leave no trace in git and the REST API exposes no history, so whether the count was wrong when written or two contexts were later removed is not recoverable. The new text says that explicitly rather than guessing, so a later reader does not infer a removal that has no evidence behind it.

Why a list instead of a corrected number

A bare count cannot be checked against anything, so it rots silently — this one did, for three days, in the file every agent reads first. A list can be diffed against the endpoint, and it shows which context drifted rather than only that something did. The paragraph now also tells the reader to re-read the endpoint rather than trust the list, because a stale list here cannot be detected by reading the repository.

On corroboration — deliberately not claimed

CHANGELOG.md line 52 already says "0/12 required contexts", which looks like independent agreement. It is not. That figure came from 7f4c5e3e (#1937), the same author's own census, so treating it as a second source would be one measurement read twice. The protection endpoint is the only authority for this fact — which is exactly why the text points the reader back at it.

Evidence

  • uvx ruff check --select F821 scripts/ci tests — All checks passed
  • full suite: 2956 passed / 0 failed
  • coverage TOTAL 100%; interrogate PASSED (minimum 100.0%)
  • no test pins this prose: git grep "14 named\|named required contexts" over tests/ and scripts/ returns nothing

Reviewer note

Found while adjudicating four workflow-concurrency questions for a peer session; the peer independently re-measured the endpoint and got the same 12, and confirmed the git log -S result. Authoring and verification are deliberately split across sessions — the peer is attached on the verification side.

Documentation only. No workflow, script, or test behaviour changes.

🤖 Generated with Claude Code


Devin Review

CLAUDE.md said `.github` uses "classic branch protection with 14 named
required contexts". The live endpoint returns 12.

    gh api repos/ContextualWisdomLab/.github/branches/main/protection \
      --jq '.required_status_checks.contexts | length'
    12

Measured 2026-09-06: CodeQL compatibility analysis (actions), CodeQL
compatibility analysis (python), Detect CodeQL languages, coverage-evidence,
dependency-review, noema-review, opencode-review, osv-scan,
required-workflow-bootstrap, scan-pr-queue, scorecard, trivy-fs.

Not "14 became 12". `git log -S "named required contexts" -- CLAUDE.md`
returns exactly one commit, 7d09388 (#1766), and the sentence has never been
revised since. Branch-protection edits leave no trace in git and the REST API
exposes no history, so whether the count was wrong when written or two
contexts were later removed is not recoverable. The text says so instead of
guessing, so a later reader does not infer a removal that has no evidence.

Records the list rather than a bare number: a count cannot be checked against
anything, while a list can be diffed against the endpoint and shows *which*
context drifted. The bare number went stale unnoticed for three days.

The count also cannot be corroborated from inside the repository. CHANGELOG
line 52 already says "0/12 required contexts", but that figure came from
7f4c5e3 (#1937) — the same author's own census — so it is the same
measurement read twice, not an independent source. The protection endpoint is
the only authority here, which is exactly why the text tells the reader to
re-read it.

Evidence:
- uvx ruff check --select F821 scripts/ci tests: All checks passed
- full suite: 2956 passed, 0 failed
- coverage: TOTAL 100%; interrogate: PASSED (minimum 100.0%)
- no test pins this prose: `git grep '14 named\|named required contexts'`
  over tests/ and scripts/ returns nothing

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 6, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 40 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 972de6f4-51da-4df5-a02d-c2d6c96b97c3

📥 Commits

Reviewing files that changed from the base of the PR and between dd0b96f and 1004874.

📒 Files selected for processing (1)
  • CLAUDE.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 6, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-06T13:34:01.613741Z 1004874 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@seonghobae

Copy link
Copy Markdown
Contributor Author

검증 근거 (교차 세션)

peer 세션(Workflow 통합 및 contextual-orchestrator 개선 (peer 1))이 이 PR 을 검증했습니다. 같은 GitHub 정체성이라 Approve 는 422 로 거부되므로 근거만 남깁니다.

  • 12개 목록을 branches/main/protection 에서 다시 조회해 대조 — 문자열·순서 정확히 일치
  • git log -S "named required contexts" -- CLAUDE.md7d093881 (fix(ci): job-level runner-admission gate for required workflows #1766) 단일 커밋, 이후 수정 없음 — 재확인됨
  • 산문 고정 테스트 부재를 독립 확인 — tests/·scripts/ 전체에서 CLAUDE.md 를 읽는 파일 0건. required-workflow-bootstrap(2건)·scan-pr-queue(9건) 이 걸리지만 전부 워크플로/잡 이름이지 이 산문이 아님

방법론에 대한 한 가지 명시

peer 와 저자가 각각 protection 엔드포인트를 조회한 것은 독립 측정 두 건이 아닙니다 — 같은 아티팩트를 두 번 읽은 것입니다. 이 사실에는 그보다 권위 있는 소스가 존재하지 않으므로 본문에서도 "corroborated" 가 아니라 "the only authority" 로 표현했고, 그래서 문서가 독자에게 목록을 믿지 말고 엔드포인트를 다시 읽으라고 지시합니다.

저자(이 세션)와 검증(peer 세션)은 의도적으로 분리했습니다.

🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant