Skip to content

πŸ›‘οΈ Sentinel: [security improvement] Fix implicit shell usage in probe capability #1934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seonghobae wants to merge 2 commits into
base: main
Choose a base branch
from
+3 βˆ’0
Open

πŸ›‘οΈ Sentinel: [security improvement] Fix implicit shell usage in probe capability #1934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74b8586
πŸ›‘οΈ Sentinel: [security improvement] Fix implicit shell usage in probe…
seonghobae Sep 5, 2026
3509d9f
πŸ›‘οΈ Sentinel: [security improvement] Fix implicit shell usage in probe…
seonghobae Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scripts/ci/sandboxed_web_e2e.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,7 @@ def _probe_isolation_capability(backend: str) -> None:
text=True,
timeout=10,
check=False,
shell=False,
)
except (OSError, subprocess.TimeoutExpired) as exc:
raise RuntimeError(f"bubblewrap capability probe could not run: {exc}") from exc
Expand Down
2 changes: 2 additions & 0 deletions tests/test_sandboxed_web_e2e.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1396,6 +1396,7 @@ def test_probe_isolation_capability_exercises_the_same_operations_as_real_comman

def _fake_run(command, **kwargs):
captured["command"] = command
captured["kwargs"] = kwargs
return subprocess.CompletedProcess(command, 0, stdout="", stderr="")

monkeypatch.setattr(sandboxed_web_e2e.subprocess, "run", _fake_run)
Expand All @@ -1408,6 +1409,7 @@ def _fake_run(command, **kwargs):
assert "--bind" in command
assert sandboxed_web_e2e.SANDBOX_MOUNT in command
assert "--chdir" in command
assert captured["kwargs"].get("shell") is False


def test_probe_isolation_capability_ignores_path_shadowed_shell(monkeypatch, tmp_path):
Expand Down
Loading