fix(noema): restore null synchronous model timeout - #1893
Closed
seonghobae wants to merge 3 commits into
Closed
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Protected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
Protected
.github/main@bc59c07c448dcfa1b8fbc64b601550d232697f24changed Noema's synchronous model execution from the established null-timeout contract to a 15-minute step deadline plus a 30-minute job deadline. The same commit rewrotedocs/product-goal-directive.mdfrom accepting long-running OpenCode/Strix/Noema model execution to requiring completion within 900 seconds.That is not an administrative-only wait bound.
Prepare Noema model verdictcalls the contextual-orchestrator-backed model synchronously, so a step/job wall-clock cap terminates reasoning/stream/tool-call execution solely because elapsed time expired. Noema must distinguish provider/session termination and explicit administrative cancellation from inference elapsed time; provider/model routing remains owned by contextual-orchestrator.RED → causal repair
3e1c5f651293c3aed3f2676269b6a22e05f134c3restores the pre-regression executable contract intests/test_noema_orchestrator_workflow_contract.pywhile leaving the 900-second production timeout in place.f51960058d12a5c44d799ccb76ce2f6fe8b98c6brestores the pre-fix(noema): bound model runtime to 900 seconds #1890 Noema workflow/docs/test surfaces: nonoema-reviewjob deadline, noPrepare Noema model verdictstep deadline, and the long-running/null-timeout directive.58c7b045af9c095106e76a233037d19deb2db3c7(fix(opencode): bound model runtime to 900 seconds #1892) on unrelated OpenCode/Strix contract files. Ordinary two-parent merge1bd22d048c9aff38ab05cc5f55633e22f2e002a7non-force restacks the Noema repair on that exact protected head while retaining fix(opencode): bound model runtime to 900 seconds #1892's tree. Fresh compare is ahead with merge-base exactly58c7b045af9c095106e76a233037d19deb2db3c7; only the four Noema timeout surfaces differ.The repair intentionally does not change Strix's separately merged #1889 state, provider/model selection, credentials,
orchestrator/free, runner selectors, queue policy, security/quarantine/outbound authority, or any product repository domain truth.Current exact authority
main@58c7b045af9c095106e76a233037d19deb2db3c7;1bd22d048c9aff38ab05cc5f55633e22f2e002a7;33946322090— queued/non-passing;33946322078— queued/non-passing;33946321978— pending/non-passing;33946321956— pending/non-passing;33946322004— queued/non-passing.Verification discipline
Keep Draft until exact-head central CI/security/reviewer/coverage/workflow-contract evidence is terminal GREEN with zero valid unresolved findings. If protected main advances, non-force restack and re-audit only the intervening delta. Do not reintroduce a synchronous Noema inference wall-clock bound as a queue-starvation workaround; shared-runner starvation remains the organization control-plane problem tracked separately.