Skip to content

fix(strix): remove repository-side scan retries - #1880

Merged
seonghobae merged 2 commits into
mainfrom
codex/remove-strix-outer-retry
Sep 5, 2026
Merged

fix(strix): remove repository-side scan retries#1880
seonghobae merged 2 commits into
mainfrom
codex/remove-strix-outer-retry

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Summary

  • invoke the trusted Strix gate once per workflow run
  • remove repository-side full-scan retry/backoff knobs and sleep
  • keep contextual-orchestrator responsible for provider discovery, repair, and failover
  • preserve scanner-level fail-closed vulnerability and infrastructure classification

Verification

  • actionlint .github/workflows/strix.yml
  • focused pytest: 64 passed
  • pytest -q tests/test_strix*.py: 109 passed, 21 subtests passed
  • bash scripts/ci/test_strix_quick_gate.sh: PASS (exit 0)

This replaces the queue-reduction portion of #1668 without changing the shared model normalizer or breaking manual/provider-specific gate tests.

Signed-off-by: Seongho Bae <me@seonghobae.me>
@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 50 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: e1ed2f2d-9faf-4116-931f-9ee9fa953e8d

📥 Commits

Reviewing files that changed from the base of the PR and between bfda38b and fd36a57.

📒 Files selected for processing (2)
  • .github/workflows/strix.yml
  • tests/test_strix_backend_unavailable_after_exempted_finding.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae merged commit 8272e4f into main Sep 5, 2026
4 of 16 checks passed
@seonghobae
seonghobae deleted the codex/remove-strix-outer-retry branch September 5, 2026 02:09
seonghobae added a commit that referenced this pull request Sep 5, 2026
One conflict in tests/test_strix_backend_unavailable_after_exempted_finding.py:
both sides added a workflow-contract method at the same spot. main's (#1880)
is a superset of this branch's -- it also asserts the retry knobs are absent
and shares the no-wall-clock-deadline tail -- so main's method is kept and
the branch's duplicate header dropped. No production code touched by hand.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant