docs(opencode-review): fix stale comment describing the pre-#1781 design - #1785
Merged
Merged
Conversation
Flagged by host 1 (relayed via peer 1): cancel-superseded-opencode-review-runs' own comment still described "exact-head concurrency" protecting the newer run -- that mechanism was removed in #1781 (bootstrap group is now cancel-in-progress: false, scoped by repo+PR-number only). While fixing it, found this job's actual role is more significant than its old "defense in depth" framing suggested: it's a precise, live-head- reverified, API-based sweep that already implements "cancel only outdated runs of the same PR" (re-checks the live head immediately before selecting cancellation candidates AND immediately before every individual cancel call), so it's immune to #1568's order-blind-preemption bug by construction. Now that the bootstrap group no longer auto-cancels anything natively, this job is the primary active-cancellation path, not a backup. Rewrote the comment to say so. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesOpenCode 리뷰 실행 취소 설명
Estimated code review effort: 1 (매우 낮음) | ~2분 Suggested reviewers: ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Flagged by host 1 (relayed via peer 1):
cancel-superseded-opencode-review-runs's own comment still described "exact-head concurrency" protecting the newer run — that mechanism was removed in #1781 (bootstrap group is nowcancel-in-progress: false, scoped by repo+PR-number only).While fixing it, found this job's actual role is more significant than its old "defense in depth" framing suggested: it's a precise, live-head-reverified, API-based sweep that already implements "cancel only outdated runs of the same PR" — it re-checks the live head immediately before selecting cancellation candidates AND immediately before every individual cancel call, so it's immune to #1568's order-blind-preemption bug by construction (it targets by head-SHA mismatch, not "whichever run started most recently"). Now that the bootstrap group no longer auto-cancels anything natively, this job is the primary active-cancellation path, not a backup. Rewrote the comment to say so.
Docs-only change — no behavioral difference.
Test plan
coverage run -m pytest tests && coverage report --show-missing— 2681 passed, 1 skipped, 100% coverage.python3 -c "import yaml; yaml.safe_load(open('.github/workflows/opencode-review.yml'))"— parses.🤖 Generated with Claude Code
Summary by CodeRabbit