test(review): lock split target and central mention authority - #1623
Open
seonghobae wants to merge 13 commits into
Open
test(review): lock split target and central mention authority#1623seonghobae wants to merge 13 commits into
seonghobae wants to merge 13 commits into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Preserve the current writer history while joining protected main. The effective delta is limited to permanent assertions that sibling target access and central repository_dispatch use distinct credentials.
Preserve the exact split-authority regression while carrying protected-main OpenCode queue-capacity changes. The two branch test files do not overlap main's intervening workflow/contract edits.
seonghobae
enabled auto-merge (squash)
September 1, 2026 18:02
seonghobae
enabled auto-merge (squash)
September 1, 2026 19:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified review-evaluation case
A current-head Devin review correctly identified that this branch had crossed two distinct authority domains: the organization sweep needs a cross-repository credential to read and acknowledge sibling PRs, but
agent_mention_router.dispatch_request()always publishes wrapper events toContextualWisdomLab/.github. Replacing the central job token with the target/App credential can therefore make the installation-fallback path unable to dispatch the central workflow.The original branch hypothesis was falsified. Protected current
main@4ae90e18b03a3a455e13e501628010cabc5c37a8already has the correct split: target reads use the selected organization/App credential while central artifact lookup andrepository_dispatchuse the.githubjob-scopedgithub.tokenwith job-scopedcontents: write.Finding-to-fix closure
AGENT_DISPATCH_TOKEN: ${{ github.token }}in the sweep and rejectexport AGENT_DISPATCH_TOKEN="$TARGET_REPOSITORY_TOKEN".repos/ContextualWisdomLab/.github/dispatcheswhile acknowledgements mutate only the target repository.This converts a demonstrated external-review finding into a durable Noema/OpenCode false-negative/false-positive evaluation case for internal-vs-external authority-boundary overreach, instead of shipping the initially proposed fix.
Scope and acceptance
This PR no longer claims that the target/dispatch credential split caused
semantic-data-portal#81to miss an OpenCode verdict. That incident remains a separate causal investigation and must not be 'fixed' by broadening or conflating credential authority.Current exact head:
e30ccae6f0fc8c16f7b67650d0523d1639f10281.Require fresh exact-head checks/review evidence and ordinary protected-branch admission. No gate, approval, merge authority, or external-write scope is expanded.