Skip to content

test(review): lock split target and central mention authority - #1623

Open
seonghobae wants to merge 13 commits into
mainfrom
fix/agent-mention-dispatch-credential-current-main
Open

test(review): lock split target and central mention authority#1623
seonghobae wants to merge 13 commits into
mainfrom
fix/agent-mention-dispatch-credential-current-main

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Verified review-evaluation case

A current-head Devin review correctly identified that this branch had crossed two distinct authority domains: the organization sweep needs a cross-repository credential to read and acknowledge sibling PRs, but agent_mention_router.dispatch_request() always publishes wrapper events to ContextualWisdomLab/.github. Replacing the central job token with the target/App credential can therefore make the installation-fallback path unable to dispatch the central workflow.

The original branch hypothesis was falsified. Protected current main@4ae90e18b03a3a455e13e501628010cabc5c37a8 already has the correct split: target reads use the selected organization/App credential while central artifact lookup and repository_dispatch use the .github job-scoped github.token with job-scoped contents: write.

Finding-to-fix closure

  • Re-fetched the writer branch before mutation and preserved concurrent commits.
  • Reverted the unsafe production/config change and the contradictory documentation back to the protected-main contract.
  • Replaced the RED assertions that demanded credential aliasing with permanent assertions that require AGENT_DISPATCH_TOKEN: ${{ github.token }} in the sweep and reject export AGENT_DISPATCH_TOKEN="$TARGET_REPOSITORY_TOKEN".
  • Preserved the existing executable router regression where separate fake target and central clients prove wrapper dispatches go only to repos/ContextualWisdomLab/.github/dispatches while acknowledgements mutate only the target repository.
  • Joined current protected main without force-push; the effective current-main delta is only the two regression-test files.

This converts a demonstrated external-review finding into a durable Noema/OpenCode false-negative/false-positive evaluation case for internal-vs-external authority-boundary overreach, instead of shipping the initially proposed fix.

Scope and acceptance

This PR no longer claims that the target/dispatch credential split caused semantic-data-portal#81 to miss an OpenCode verdict. That incident remains a separate causal investigation and must not be 'fixed' by broadening or conflating credential authority.

Current exact head: e30ccae6f0fc8c16f7b67650d0523d1639f10281.

Require fresh exact-head checks/review evidence and ordinary protected-branch admission. No gate, approval, merge authority, or external-write scope is expanded.


Devin Review

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 5ff00835-0daf-429b-bd05-c271429f0470


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

devin-ai-integration[bot]

This comment was marked as resolved.

@seonghobae seonghobae changed the title fix(review): dispatch mention sweep with cross-repository credential test(review): preserve central dispatch authority in mention sweep Sep 1, 2026
Preserve the current writer history while joining protected main. The effective delta is limited to permanent assertions that sibling target access and central repository_dispatch use distinct credentials.
@seonghobae seonghobae changed the title test(review): preserve central dispatch authority in mention sweep test(review): lock split target and central mention authority Sep 1, 2026

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 new potential issues.

Devin Review

Comment thread tests/test_agent_mention_downstream_idempotency.py
Comment thread tests/test_agent_mention_workflow_contract.py
Preserve the exact split-authority regression while carrying protected-main OpenCode queue-capacity changes. The two branch test files do not overlap main's intervening workflow/contract edits.
@seonghobae
seonghobae enabled auto-merge (squash) September 1, 2026 18:02
@opencode-agent
opencode-agent Bot disabled auto-merge September 1, 2026 18:03
@seonghobae
seonghobae enabled auto-merge (squash) September 1, 2026 19:07
@opencode-agent
opencode-agent Bot disabled auto-merge September 2, 2026 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance priority: medium Normal-priority or P2 work type: maintenance Maintenance, build, dependency, or operational upkeep

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant