-
Notifications
You must be signed in to change notification settings - Fork 0
fix(ci): remove heuristic review catalog admission caps #1591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
f1cdfac
test(ci): reject heuristic review catalog truncation
seonghobae 14cd352
fix(ci): remove heuristic review catalog truncation
seonghobae 9d9fbe7
test(ci): align policy suite with evidence-only admission
seonghobae 6bb7a2c
Merge protected main into no-heuristic review admission
seonghobae 53f128e
chore(ci): repair PR 1591 launcher cap contract
seonghobae c2ab744
fix(ci): make legacy catalog caps truly non-authoritative
seonghobae 01f6f5d
test(ci): prove retired catalog caps are not inspected
seonghobae ed57d8d
chore(ci): stage PR 1591 repair driver
seonghobae aced2f7
fix(ci): make PR 1591 repair workflow parseable
seonghobae 031bfbe
chore(ci): resume PR 1591 repair after concurrent policy fix
seonghobae 140609c
fix(ci): resume PR 1591 repair on concurrent head
seonghobae 1de1a89
fix(ci): retire stale legacy-cap test during 1591 repair
seonghobae 1b43cad
fix(ci): retrigger 1591 repair after stale-test correction
seonghobae d72ef12
fix(ci): reconcile 1591 with current main before repair
seonghobae c06bd95
fix(ci): resolve the verified 1591 current-main test conflict
seonghobae ac048d2
merge current main into no-heuristic admission repair
github-actions[bot] 7309388
fix(review): remove launcher catalog admission caps
github-actions[bot] ea90103
chore(ci): remove completed PR 1591 repair workflow
seonghobae 7c14238
chore(ci): remove completed PR 1591 repair driver
seonghobae baeae65
chore(ci): remove completed PR 1591 resume driver
seonghobae d2f289d
merge current main into no-heuristic admission repair
seonghobae daced8b
docs(adr): remove retired heuristic review contracts
seonghobae ddc023d
chore(ci): stage one-shot preflight escalation-order repair
seonghobae 2e0badd
Merge remote-tracking branch 'origin/main' into fix/no-heuristic-free…
github-actions[bot] fa9d87d
test(review): expose order-sensitive preflight escalation
github-actions[bot] 0c99f24
fix(ci): update PR 1591 escalation repair harness
seonghobae 34409d0
fix(ci): make 1591 RED publication idempotent
seonghobae b7687e2
docs(adr): restore sidecar pin and no-timeout invariants
seonghobae 0c5d6c8
fix(ci): align 1591 ADR and stale contracts before GREEN
seonghobae 53f1fa5
fix(ci): stage ADR repair with 1591 GREEN commit
seonghobae ae917f6
Merge remote-tracking branch 'origin/main' into fix/no-heuristic-free…
github-actions[bot] 9faf8ff
fix(review): remove shared preflight escalation quota
github-actions[bot] 095e7a6
chore(ci): remove completed PR 1591 escalation repair workflow
seonghobae e091dd3
chore(ci): remove completed PR 1591 escalation repair driver
seonghobae 2d72b28
chore(ci): remove completed PR 1591 escalation resume driver
seonghobae de390d7
test(ci): forbid retired review pool and identity collisions
seonghobae 66e9905
test(ci): scope free-only contract to central launcher
seonghobae d96aa63
test(ci): central review sidecar rejects retired auto pool
seonghobae 6e28b2e
chore(ci): add exact-head free identity repair driver
seonghobae c363488
chore(ci): add PR1591 free identity source fix
seonghobae f1a851c
chore(ci): trigger PR1591 free identity source fix
seonghobae 02103dd
test(ci): align central sidecar contract with free-only policy
seonghobae 395d252
chore(ci): reserve exact-head restoration point
seonghobae 34bbbd3
chore(ci): stage exact contract restoration
seonghobae 2f03741
chore(ci): temporary restore marker 2
seonghobae f293852
chore(ci): restore full sidecar contract before repair
seonghobae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| repair central free-only reachability and runtime identity collision | ||
| attempt=v1-red-green |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,97 @@ | ||
| name: Source fix PR1591 free identity | ||
|
|
||
| on: | ||
| push: | ||
| branches: [fix/no-heuristic-free-review-admission] | ||
| paths: [.github/source-fix-1591-free-identity.trigger] | ||
|
|
||
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
|
|
||
| jobs: | ||
| repair: | ||
| runs-on: ubuntu-24.04 | ||
| steps: | ||
| - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 | ||
| with: | ||
| ref: fix/no-heuristic-free-review-admission | ||
| fetch-depth: 0 | ||
| persist-credentials: false | ||
| - uses: actions/setup-python@ece7cb06caefa5fff74198d8649806c4678c61a1 # v6 | ||
| with: | ||
| python-version: "3.12" | ||
| - name: Install exact test dependencies | ||
| run: >- | ||
| python -m pip install --disable-pip-version-check --require-hashes | ||
| --only-binary=:all: -r requirements-opencode-review-ci-hashes.txt | ||
| - name: Verify RED contract and apply owner-side repair | ||
| id: patch | ||
| env: | ||
| GH_TOKEN: ${{ github.token }} | ||
| run: | | ||
| set -euo pipefail | ||
| branch_name='fix/no-heuristic-free-review-admission' | ||
| starting_head="$GITHUB_SHA" | ||
| echo "starting_head=$starting_head" >>"$GITHUB_OUTPUT" | ||
| live_ref="$(gh api "repos/${GITHUB_REPOSITORY}/git/ref/heads/${branch_name}" --jq '.object.sha')" | ||
| pr_state="$(gh api "repos/${GITHUB_REPOSITORY}/pulls/1591" --jq '.state')" | ||
| pr_head_ref="$(gh api "repos/${GITHUB_REPOSITORY}/pulls/1591" --jq '.head.ref')" | ||
| test "$live_ref" = "$starting_head" | ||
| test "$pr_state" = open | ||
| test "$pr_head_ref" = "$branch_name" | ||
|
|
||
| if python -m pytest -q \ | ||
| tests/test_contextual_orchestrator_no_heuristic_admission.py \ | ||
| tests/test_contextual_orchestrator_central_free_only.py; then | ||
| echo '::error::PR #1591 RED regressions unexpectedly pass before production repair.' | ||
| exit 91 | ||
| fi | ||
|
|
||
| python scripts/ci/source_fix_1591_free_identity.py | ||
|
|
||
| python -m pytest -q \ | ||
| tests/test_contextual_orchestrator_no_heuristic_admission.py \ | ||
| tests/test_contextual_orchestrator_central_free_only.py \ | ||
| tests/test_contextual_orchestrator_review_policy.py \ | ||
| tests/test_contextual_orchestrator_review_runtime_preflight.py \ | ||
| tests/test_contextual_orchestrator_review_sidecar_contract.py \ | ||
| tests/test_contextual_orchestrator_free_credential_admission.py \ | ||
| tests/test_contextual_orchestrator_review_live_discovery_contract.py | ||
| python -m coverage run -m pytest tests -q | ||
| python -m coverage report --fail-under=100 | ||
| python -m interrogate --fail-under=100 scripts/ci | ||
| git diff --check | ||
|
|
||
| latest_ref="$(gh api "repos/${GITHUB_REPOSITORY}/git/ref/heads/${branch_name}" --jq '.object.sha')" | ||
| latest_state="$(gh api "repos/${GITHUB_REPOSITORY}/pulls/1591" --jq '.state')" | ||
| latest_head_ref="$(gh api "repos/${GITHUB_REPOSITORY}/pulls/1591" --jq '.head.ref')" | ||
| test "$latest_ref" = "$starting_head" | ||
| test "$latest_state" = open | ||
| test "$latest_head_ref" = "$branch_name" | ||
|
|
||
| rm -f \ | ||
| .github/workflows/source-fix-1591-free-identity.yml \ | ||
| .github/source-fix-1591-free-identity.trigger \ | ||
| scripts/ci/source_fix_1591_free_identity.py | ||
| git add -A | ||
| git diff --cached --check | ||
| git config user.name 'opencode-agent[bot]' | ||
| git config user.email '219766164+opencode-agent[bot]@users.noreply.github.com' | ||
| git commit -m 'fix(ci): close central free-pool identity gaps' | ||
|
|
||
| - name: Push repaired exact head | ||
| env: | ||
| GH_TOKEN: ${{ secrets.PR_REVIEW_MERGE_TOKEN || secrets.OPENCODE_APPROVE_TOKEN }} | ||
| STARTING_HEAD: ${{ steps.patch.outputs.starting_head }} | ||
| run: | | ||
| set -euo pipefail | ||
| if [ -z "${GH_TOKEN:-}" ]; then | ||
| echo '::error::No event-capable branch-write credential is configured.' | ||
| exit 1 | ||
| fi | ||
| branch_name='fix/no-heuristic-free-review-admission' | ||
| remote_head="$(gh api "repos/${GITHUB_REPOSITORY}/git/ref/heads/${branch_name}" --jq '.object.sha')" | ||
| test "$remote_head" = "$STARTING_HEAD" | ||
| gh auth setup-git | ||
| git push origin HEAD:"$branch_name" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 Temporary repair machinery remains
The operating directive requires completed source-fix workflows to be removed. This workflow, its trigger, and repair driver remain tracked despite the claimed cleanup.
Was this helpful? React with 👍 or 👎 to provide feedback.