Skip to content

fix(test): eliminate scheduler-wake SIGPIPE flake #1561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 1 commit into from
+11 −0
Closed

fix(test): eliminate scheduler-wake SIGPIPE flake #1561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,16 @@ this file. The format follows Keep a Changelog, and versioned releases follow
Semantic Versioning where the repository publishes a release.

## [Unreleased]
- Fix a flaky SIGPIPE (exit 141) in
`test_scheduler_wake_reuses_trusted_receipt_predicate`: the fixture's fake
`gh` never read stdin on its `repos/ContextualWisdomLab/.github/dispatches`
branch, racing the real production pipe (`jq -cn ... | gh api -X POST
.../dispatches --input -`) — an early-exiting non-stdin-reading downstream
reader can SIGPIPE the upstream writer depending on process-scheduling
timing. Reproduced locally (~1/20 runs) and confirmed test-harness-only,
not a production bug (the real `gh api --input -` does read stdin). Fixed
by draining stdin (`cat >/dev/null`) before that branch proceeds; 60/60
clean runs after the fix.
- Avoid redundant merge-scheduler wakes when the trusted receipt predicate
already finds a substantive exact-head OpenCode verdict. Missing, stale, or
fallback-only evidence still dispatches review work, while receipt lookup or
Expand Down
1 change: 1 addition & 0 deletions tests/test_opencode_required_verdict_regression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@ def test_scheduler_wake_reuses_trusted_receipt_predicate(
elif [[ "$*" == *"/pulls/7/reviews"* ]]; then
printf '[%s]' "$FAKE_REVIEWS"
elif [[ "$*" == *"repos/ContextualWisdomLab/.github/dispatches"* ]]; then
cat >/dev/null
printf 'dispatch\n' >>"$DISPATCH_CALLS"
fi
""",
Expand Down
Loading