Skip to content

Revert "fix(opencode): proceed on head-only advance in review dispatch validation (#1533)" #1540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seonghobae merged 1 commit into from
Sep 1, 2026
Merged

Revert "fix(opencode): proceed on head-only advance in review dispatch validation (#1533)" #1540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions .github/workflows/opencode-review-dispatch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,20 +199,11 @@ jobs:
[ "$SUPPLIED_BASE_REF" = "$live_base_ref" ] || mismatches+=("base_ref")
[ "$SUPPLIED_BASE_SHA" = "$live_base_sha" ] || mismatches+=("base_sha")
[ "$SUPPLIED_HEAD_REF" = "$live_head_ref" ] || mismatches+=("head_ref")
[ "$SUPPLIED_HEAD_SHA" = "$live_head_sha" ] || mismatches+=("head_sha")
if [ "${#mismatches[@]}" -gt 0 ]; then
printf '::error::repository_dispatch metadata does not match the live pull request: %s. supplied_base=%s/%s live_base=%s/%s supplied_head=%s/%s live_head=%s/%s\n' "$(IFS=,; printf '%s' "${mismatches[*]}")" "${SUPPLIED_BASE_REF:-<empty>}" "${SUPPLIED_BASE_SHA:-<empty>}" "$live_base_ref" "$live_base_sha" "${SUPPLIED_HEAD_REF:-<empty>}" "${SUPPLIED_HEAD_SHA:-<empty>}" "$live_head_ref" "$live_head_sha"
exit 1
fi
# A head advance between dispatch capture and this job is normal PR
# activity, and Actions queue backlog widens the window. Every
# downstream job consumes the re-fetched live head_sha emitted below
# and independently re-checks it against the live PR head with
# STALE_HEAD guards, so a head_sha-only change is not a trust failure:
# warn and proceed on the current head instead of failing closed and
# leaving the required review check with no verdict.
if [ -n "$SUPPLIED_HEAD_SHA" ] && [ "$SUPPLIED_HEAD_SHA" != "$live_head_sha" ]; then
printf '::warning::repository_dispatch head advanced since dispatch: supplied_head_sha=%s live_head_sha=%s; proceeding with the live head.\n' "$SUPPLIED_HEAD_SHA" "$live_head_sha"
fi
fi

{
Expand Down
Loading