Skip to content

fix(ci): correct required-workflow-bootstrap job-scope check boundary #1528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 1 commit into from
Closed

fix(ci): correct required-workflow-bootstrap job-scope check boundary #1528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,18 @@ this file. The format follows Keep a Changelog, and versioned releases follow
Semantic Versioning where the repository publishes a release.

## [Unreleased]
- Fix `scripts/ci/test_strix_quick_gate.sh`'s `required-workflow-bootstrap` job-scope
check: its `awk` range used `/^[^ ]/` as the end pattern, which only matches a
fully-unindented line and so never stopped at the next 2-space-indented job
header — it silently swept every later job in `opencode-review.yml`
(`coverage-source-tree`, `coverage-evidence`, `opencode-review-target`) into
the check. That was latent until `#1497` ("require substantive agent
verdicts") added a genuine step-level `if: github.event.action != 'closed'`
inside `opencode-review-target`, which the over-broad range then
misattributed to `required-workflow-bootstrap` (which has no `if:` at all
and was always compliant), failing `exact-head-path-policy` on every open
PR in this repository. The corrected range now exits as soon as it reaches
the next 2-space-indented job header.
- Harden the review sidecar's per-account catalog cap against silent drift:
`contextual_orchestrator_review_launcher.py`'s two
`build_zdr_prioritized_catalog` call sites now source their
Expand Down
6 changes: 5 additions & 1 deletion scripts/ci/test_strix_quick_gate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,11 @@ assert_opencode_review_uses_codegraph_and_contextual_orchestrator() {
assert_file_not_contains "$workflow_file" "Wait for trusted OpenCode approval review" "opencode pull_request bridge was removed to avoid duplicate required-check resource use"
assert_file_not_contains "$workflow_file" "Trusted OpenCode requested changes for head" "opencode pull_request bridge no longer reconsumes stale trusted review state"
assert_file_not_contains "$workflow_file" "github.event.pull_request.number == 240" "opencode review workflow must not hard-code repository-specific PR bypasses"
if awk '/^ required-workflow-bootstrap:$/,/^[^ ]/' "$bootstrap_file" | grep -q '^[[:space:]]*if:'; then
if awk '
/^ required-workflow-bootstrap:$/ { found=1; print; next }
found && /^ [A-Za-z0-9_-]+:$/ { exit }
found { print }
' "$bootstrap_file" | grep -q '^[[:space:]]*if:'; then
record_failure "opencode required workflow bootstrap must not depend on required-workflow event payload fields"
fi
assert_file_contains "$workflow_file" 'github.event.client_payload.target_repository || github.repository' "opencode review scopes concurrency by target repository"
Expand Down
Loading