Skip to content

fix(ci): remove stale hardcoded timeout-minutes claim from sidecar comment #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 3 commits into from
Closed

fix(ci): remove stale hardcoded timeout-minutes claim from sidecar comment #1510

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
817891c
fix(ci): remove stale hardcoded timeout-minutes claim from sidecar co…
claude Aug 31, 2026
a463b7e
fix(ci): correct sidecar comment's noema-review.yml timeout claim
claude Sep 1, 2026
58af782
fix(ci): cover pr-review-autofix.yml as a third timeout-less sidecar …
claude Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions scripts/ci/contextual_orchestrator_review_sidecar.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,9 +428,16 @@ printf '{"model":"%s","messages":[{"role":"system","content":"You are a helpful
# in 18s, then this identical request against that same healthy route being
# cut off by curl's own timeout at exactly 30.0s -- "gateway preflight
# request could not reach the local sidecar" is this curl failure, not an
# actual connectivity problem. This required-workflow job already budgets
# 120 minutes (see timeout-minutes in strix.yml/noema-review.yml), and the
# org's own stated policy accepts multi-hour central review latency in
# actual connectivity problem. The calling job's own outer bound already
# gives multi-hour headroom for this required-workflow job regardless of
# which caller invokes this script: strix.yml's job-level timeout-minutes
# is 200; noema-review.yml's `noema-review` job and pr-review-autofix.yml's
# job that runs this script both set no job-level timeout-minutes at all,
# so their outer bound is GitHub Actions' own 360-minute default. Do not
# assume this list of callers or their timeout values is exhaustive or
# durable -- check each caller workflow directly rather than trusting this
# comment if it matters at the time of reading. Either way, the org's own
Comment on lines +431 to +439

@devin-ai-integration devin-ai-integration Bot Sep 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Info: Non-exhaustive caller list remains accurate

opencode-review-dispatch also calls the sidecar with a 325-minute bound. The explicit non-exhaustive warning prevents its omission from misleading readers.

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

# stated policy accepts multi-hour central review latency in
# favor of accuracy over speed -- a 30s bound on one preflight self-check
# contradicted that policy and rejected a route the routing probe had just
# proven healthy. 120s keeps this a bounded, fail-closed check while giving
Expand Down
Loading