-
Notifications
You must be signed in to change notification settings - Fork 0
fix(strix): disable streaming to route around contextual-orchestrator's stale invalid_stream_options rejection #1447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
seonghobae
wants to merge
1
commit into
main
from
fix/strix-disable-streaming-orchestrator-usage-gap
+19
−0
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -743,6 +743,25 @@ jobs: | |
| # The gateway auto pool is provider-diverse. Strix function tools | ||
| # must not send a provider-specific reasoning setting to every route. | ||
| STRIX_REASONING_EFFORT: none | ||
| # TEMPORARY INCIDENT MITIGATION (2026-08-30): strix hardcodes | ||
| # ModelSettings(include_usage=True) for every turn | ||
| # (strix/core/inputs.py make_model_settings(), strix-agent 1.5.3) with | ||
| # no supported env var/CLI/config knob to disable just that flag while | ||
| # still streaming. contextual-orchestrator's /v1/chat/completions | ||
| # unconditionally rejects stream=true + stream_options.include_usage=true | ||
| # whenever tools are present (server.py, "invalid_stream_options"), | ||
| # which strix always sends -- so every scan through this gateway fails | ||
| # closed with a 400, org-wide, since Strix moved onto orchestrator/free | ||
| # today. LLM_DISABLE_STREAMING is a genuine, documented strix env var | ||
| # (strix/config/models.py _NonStreamingModel) that makes every turn a | ||
| # single non-streaming call, so stream_options is never sent and the | ||
| # gateway's check never fires. This trades away real-time SSE streaming | ||
| # for a working scan; it is not the fix. Revert this line once the | ||
| # tracked contextual-orchestrator fix (removing/narrowing the stale | ||
| # tool-loop stream+include_usage rejection -- the honest usage-reporting | ||
| # path it guards already works today for non-streaming tool-loop calls) | ||
| # is merged and deployed. Tracking: #1446. | ||
| LLM_DISABLE_STREAMING: "true" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| STRIX_LLM_MAX_RETRIES: 1 | ||
| STRIX_TRANSIENT_RETRY_PER_MODEL: 2 | ||
| STRIX_TRANSIENT_RETRY_BACKOFF_SECONDS: 60 | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Streaming mitigation never reaches Strix
The quick gate omits
LLM_DISABLE_STREAMINGfrom its scanner environment, so streaming stays enabled. Gateway requests still fail with 400 responses.Prompt for agents
Was this helpful? React with 👍 or 👎 to provide feedback.