-
Notifications
You must be signed in to change notification settings - Fork 0
fix(figma): retain style references and component sets #1146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
seonghobae
wants to merge
23
commits into
main
Choose a base branch
from
codex/pr1043-current-main-successor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
93aaf69
fix(agents): document Cloud Agent Figma MCP auth fallback
cursoragent 5faec22
fix(ci): pin Figma whoami to HTTPSConnection
cursoragent 91feb91
fix(agents): add Cloud Agent Figma REST file read
cursoragent 3963310
fix(ci): cap Figma REST bodies and refuse Host overrides
cursoragent 1b6474b
fix(agents): keep Figma REST design fields and branch keys
cursoragent 93e9a46
fix(figma): retain style references and component sets
seonghobae 46911c5
fix(security): annotate fixed Figma TLS sinks
seonghobae f864176
docs: record Figma file identity decision
seonghobae 38fbf9f
Merge branch 'main' of https://github.com/ContextualWisdomLab/.github…
seonghobae 83759d9
test(figma): document nested transport fixtures
seonghobae 54cb022
Merge branch 'main' into codex/pr1043-current-main-successor
seonghobae ef5183e
Merge origin/main into Figma REST successor
seonghobae f64bf3f
Merge protected main into Figma REST successor
seonghobae 0fd89fe
Merge branch 'codex/pr1043-current-main-successor' of https://github.…
seonghobae f661a8e
docs(figma): remove duplicated security notes
seonghobae fb24399
Merge branch 'main' into codex/pr1043-current-main-successor
opencode-agent[bot] 6cbe960
fix(figma): preserve node catalogs and explicit TLS
seonghobae 8ffdf4d
fix(security): audit Figma TLS sinks and pip lock
seonghobae 7b38b63
Merge current main into Figma REST fallback
seonghobae 4eb9b5a
fix(ci): make bootstrap contract pipe-safe
seonghobae b159854
fix(figma): harden direct file reader
seonghobae d2da380
fix(noema): isolate cancelled follow-up runs
seonghobae dd305b1
docs(noema): clarify cancelled-run isolation
seonghobae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| # ADR 0013: Figma Cloud-Agent REST fallback | ||
|
|
||
| - Status: Accepted | ||
| - Date: 2026-08-20 | ||
| - Owners: ContextualWisdomLab `.github` automation | ||
| - Figma File ID: N/A — this repository change is a security and API | ||
| integration helper, not a user-facing canvas or component design. | ||
|
|
||
| ## Context | ||
|
|
||
| The Figma MCP OAuth flow is available to supported desktop and CLI clients, | ||
| but a Cloud Agent cannot complete that client registration. The automation | ||
| still needs a bounded way to inspect a buyer-supplied Figma file without | ||
| printing credentials or accepting an arbitrary URL. | ||
|
|
||
| ## Decision | ||
|
|
||
| Keep desktop and CLI agents on Figma MCP. Cloud Agents use | ||
| `FIGMA_ACCESS_TOKEN` with the repository's pinned REST helpers. The helpers | ||
| pin the Figma HTTPS origin, allowlist file and node identifiers, cap response | ||
| bodies, and emit token-free outlines. No design artifact is introduced by | ||
| this infrastructure PR, which is why the Figma File ID is explicitly N/A. | ||
|
|
||
| ## Verification and rollback | ||
|
|
||
| Run `pytest -q tests/test_figma_rest_auth.py tests/test_figma_rest_file.py`. | ||
| Rollback by reverting the helper and its caller documentation; desktop/CLI | ||
| MCP remains independent. | ||
|
|
||
| ## APA 7th references | ||
|
|
||
| Figma. (2026). *File endpoints*. Figma Developer Docs. Retrieved August 20, | ||
| 2026, from https://developers.figma.com/docs/rest-api/file-endpoints/ | ||
|
|
||
| Figma. (2026). *Set up the remote server*. Figma Developer Docs. Retrieved | ||
| August 20, 2026, from | ||
| https://developers.figma.com/docs/figma-mcp-server/remote-server-installation/ | ||
|
|
||
| Fielding, R., Nottingham, M., & Reschke, J. (Eds.). (2022). *HTTP semantics* | ||
| (RFC 9110). Internet Engineering Task Force. | ||
| https://www.rfc-editor.org/rfc/rfc9110 |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.