fix(actions): bound agent mention dispatch envelopes - #1021
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Fresh ScopeWeave consumer canary confirms this exact transport defect is currently blocking review delivery, not source quality. Scheduled mention-router run |
|
Closing this RED-only predecessor because the production defect is already resolved on protected main by #1115 ( |
Addresses Devin review findings on the item-16/17 scheduler target-list drift entry and the item-32 batch-endpoint entry: - "Noema evidence changes ownership": the new "scheduler target-list drift" section was inserted in the middle of the pre-existing "Noema single-request model-control ownership -- PR #1672" entry -- between its "900-second clarification" paragraph and its own "Evidence / acceptance" closing paragraph -- so the closing paragraph (about Noema's retry/deadline fix) ended up trailing the unrelated scheduler section, reading as if it were that section's acceptance evidence. Moved the scheduler section to come after the Noema section's actual closing paragraph, restoring both entries' internal coherence and making the scheduler section the file's true final entry again. - "Structural closure precedes artifacts": the "Structural fix" paragraph described .github#1747 (the mirror file + contract test + doctoring record) in the past tense, as delivered repository state, but that PR is open and unmerged and none of those files exist on this branch or main. Reworded to say so explicitly, in the same "pending merge" framing this entry's own item-32 write-up already uses correctly. - "Cross-repository references are not linkable": bare `#1021` / path-style `contextual-orchestrator/pull/1021` references -> the binding-convention form `ContextualWisdomLab/contextual-orchestrator#1021`. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BV96rXhqoR3tYZ9AeAVur4
…n criteria Devin Review findings on PR #1730: - Finding A (comment 3913954439, item 30 polling head-change guard): Devin was wrong -- verified the in-loop guard at opencode-review.yml:467-470 already exits 0, pinned by tests/test_opencode_poll_self_retirement.py. No doc/workflow change made. - Finding B (comment 3913954605, cross-repo #1021 refs): already fixed by 3476a56 before this comment landed -- all four #1021 refs are already fully qualified ContextualWisdomLab/contextual-orchestrator#1021. No change made. - Finding C1 (comment 3914267880, multimodal free-classification mechanism): real gap, fixed. The doc's Correction attributed the exclusion to #933's serving gate, but re-traced `_unit_prices_are_free` to 51fc34b (not ba5e00c) and confirmed live + against PR #1028's own head (aabd69a) that all 8 named models fail earlier, at `_row_is_free` (no unit_pricing/is_free key on OpenRouter rows), making #1028's general_free_serving_candidates exemption inert for every model it targets. - Finding C2 (comment 3914325501, re-open criteria too narrow): real gap, fixed. Added re-open trigger (c) for the fix failing to actually admit the named models -- the exact silently-inactive-gate failure mode Finding C1 found, which the prior two triggers (text-only regression, unreliable tool-call signal) could not have caught. Both mechanism claims independently re-verified against the vendored contextual-orchestrator checkout (git log -S, PR #1028 REST status) before editing. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Test-first state
This Draft currently contains only focused regression contracts for the central review-agent mention transport. The production code is intentionally unchanged so the exact branch records the current failure before repair.
The reproduced defect is concrete: the router emits 14 top-level
repository_dispatch.client_payloadproperties for@opencode-agent, while GitHub accepts at most 10. Recent mention-router runs fail with HTTP 422 before the authoritative review scheduler is queued, blocking exact-head OpenCode review requests across CWL repositories.The regression contract also requires:
merge_mode=disabled, no branch update, no auto-merge);This is the bounded successor to stale, conflicted PR #840. It deliberately excludes that PR's unrelated uv materializer, Strix, broad OpenCode, and documentation changes.
Do not merge in the RED state.