feat(transport): add CEP-15 i/k discovery tags#44
feat(transport): add CEP-15 i/k discovery tags#44abhayguptas wants to merge 11 commits intoContextVM:masterfrom
Conversation
|
cc - @ContextVM-org |
|
The main improvement I would suggest is in |
|
Thanks, agreed. I extracted the schema-hash access into a small shared internal helper in I also kept the transformer no-op path cheap and added focused coverage for both the already-present |
|
How would you like to proceed with your prs? Should we just merge one by one or merge them all in #44 and merge them all together? |
|
We can merge them one by one in stack order. #44 contains the earlier commits in its history, but I think the separate PRs are easier to review and reason about since each one stays focused on a single step. |
|
For this time is ok, but I think that for scoped prs like this one is better to keep them in a single pr, because currently there are some comments that are sparsed between different prs and makes this a bit awkward to track |
|
That makes sense, agreed. For this round we can keep the scoped CEP-15 changes consolidated here so the review stays easier to follow, and from next time I’ll avoid splitting work like this across multiple PRs unless it is really necessary. |
|
Last thing before merge this pr, add a changeset |
|
@ContextVM-org hi, I have added the changeset. Please review it and if everything looks good then we can merge those PR's. |
ba2eaaa to
2e27fe9
Compare
2e27fe9 to
864257f
Compare
ContextVM-org
left a comment
There was a problem hiding this comment.
Just some minor comments before merge.
17033c2 to
2f30fda
Compare
fixed, please review |
Summary
This PR is the next stacked CEP-15 step on top of #38.
It adds the NIP-73 discovery tags described in CEP-15 to public
kind:11317tools/list announcements. For opted-in common-schema tools, the SDK now publishes:["i", schemaHash, toolName]for each implemented common schema["k", "io.contextvm/common-schema"]once per eventThis complements the
_meta.schemaHashwork from #38 by making common-schema providers discoverable directly through announcement tags.Changes
withCommonToolSchemas()with a pure CEP-15i/ktag producerNostrServerTransporttools/listannouncement events inAnnouncementManageri/ktag generationTests
bun test src/transport/server-transport-common-schemas.test.ts src/transport/nostr-server-transport.test.tsbun run typecheckNotes
This PR is intentionally scoped to outer announcement discovery tags only.
It builds on:
_meta.schemaHashinjection and announcement-content consistency