fix: unused client timeout and pending-request leak#33
Open
Anshumancanrock wants to merge 2 commits intoContextVM:mainfrom
Open
fix: unused client timeout and pending-request leak#33Anshumancanrock wants to merge 2 commits intoContextVM:mainfrom
Anshumancanrock wants to merge 2 commits intoContextVM:mainfrom
Conversation
Collaborator
|
This looks good, but before we can continue with this please check the rmpc sdk which will probably handle timeouts by itself so we dont have redundant code and hardcoded error codes. Also this behaviour should be symmetric in the server. There are also some conflicts. |
Collaborator
|
Do you plan to keep working on this or can we close this pr? @Anshumancanrock |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement client-side request timeout handling in NostrClientTransport.
Issue
The timeout config and constant were defined but not used, so missing responses left pending entries forever and never surfaced timeout errors.
What is Changed
DEFAULT_TIMEOUT_MS