feat: Server Cards have wrong information hierarchy; search bar is not accessible. Fixing both of them#19
Conversation
…Card components - Added `lucide-svelte` as a dependency for icon support. - Updated `LoadingCard` to support a new layout type 'server-row' for improved loading states. - Refactored `ServerCard` to display server active date and improved layout for better user experience. - Enhanced server announcements handling in queries and UI for better performance and usability.
|
@VeryVarg is attempting to deploy a commit to the ContextVM's projects Team on Vercel. A member of the Team first needs to authorize it. |
VeryVarg
changed the title
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Hmm, I'm not sure about the changes in this PR. We lost the images and colors from the servers, which makes the server page more boring. Also, I don't like the way you are stopping the subscription. It's right that we shouldn't hold a loading state indefinitely, but we could achieve the same result by using the TanStack query options for the queries, so we don't need extra machinery that creates a subscription, etc. Additionally, the new date format is a bit unnecessary and convoluted; it worked fine in a simpler way before. Maybe just focus on the UI parts for now and tackle the other improvements in a different PR so we can move forward. |
2 participants
lucide-svelteas a dependency for icon support.LoadingCardto support a new layout type 'server-row' for improved loading states.ServerCardto display server active date and improved layout for better user experience.