Allow migration of maxCodeSizeConfig to transitions.contractsizelimit#1623
Open
vdamle wants to merge 1 commit intoConsensys:masterfrom
Open
Allow migration of maxCodeSizeConfig to transitions.contractsizelimit#1623vdamle wants to merge 1 commit intoConsensys:masterfrom
vdamle wants to merge 1 commit intoConsensys:masterfrom
Conversation
* Require genesis to specify max contract size using Transitions config. * Add checks to allow migrating from a prior maxCodeSizeConfig to contractsizelimit specified in Transitions config. * Remove support for legacy max code size genesis configuration by rejecting genesis config that specifies only maxCodeSizeConfig or maxCodeSize and maxCodeSizeChangeBlock. * cosmetic enhancement to a log message on startup to include Transitions since this is useful information for node operators.
antonydenyer
suggested changes
Mar 16, 2023
Contributor
antonydenyer
left a comment
antonydenyer
left a comment
There was a problem hiding this comment.
Agreed it's been a fair amount of time. However, the docs need a tidy up first 😏
Contributor
Author
|
@antonydenyer Based on the requested change comment, I assume you'd like me to take a stab at updating the docs? If so, could you please point me to the github repo for it? https://docs.goquorum.consensys.net/ has a link to https://github.com/ConsenSys/goquorum at the top, which either does not exist or is a private repo. Let me know. |
Contributor
|
These two are my main concerns. The problem is that the examples are in a lot of places! https://github.com/ConsenSys/doc.goquorum |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FYI, given that the notice to use
Transitionsin lieu of the legacy max code size config parameters has been advertised for more than a year, I felt that it is not premature to remove support for it.Fixes: #1622