This repository was archived by the owner on May 25, 2022. It is now read-only.
Add Data instance to Record #56
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
locallycompact
force-pushed
the
lc/data
branch
2 times, most recently
from
145da5c to
6d1e95b
Compare
Contributor
Collaborator
|
This seems reasonable, but I wonder if it should really be defined in the Vinyl library, since there's nothing specific to Composite about the code that was added. If you were to do that, we might need to do some more work to get it compiling with Vinyl 0.14, since that's not allowed by our version constraints. In that case, you might just keep using your fork in the short term and we can work on supporting Vinyl 0.14. |
Collaborator
|
The latest ghc 9.2.2 branch supports vinyl 0.14, so if that was added it would get pulled in automatically. I think we could probably close this now? |
Contributor
Author
|
I think we will still need this bit Let me just check I can correctly implement the rest for |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is right