Use baton-sdk resource attribute helpers for profile/status reads - #60
Conversation
Connector PR Review: Use baton-sdk resource attribute helpers for profile/status readsBlocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0 Review SummaryThe full PR diff was scanned for security and correctness. This change swaps two direct Security IssuesNone found. Correctness IssuesNone found. SuggestionsNone. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Follow-up to the trait profile/status migration. That migration moved reads from the deprecated trait fields to the resource itself (`r.GetProfile()`). That is correct for data written by a connector which has already migrated, but it returns nothing for data synced **before** the migration, where the profile still lives on the trait annotation. baton-sdk provides compatibility getters for exactly this (`pkg/types/resource/resource_attrs.go`): `GetProfile`, `GetStatus`, `GetCreatedAt`, and `GetIcon` read the resource-level attribute first and fall back to the deprecated trait field. This switches the reads to those helpers so previously-synced data still resolves. Reads only — the write side (`WithResourceProfile` / `WithResourceStatus`) is unchanged. Reference: ConductorOne/baton-sql#143. `golangci-lint run ./...` reports 0 issues and the package tests pass.
5ca8fea to
18ffc35
Compare
1 participant
Follow-up to the trait profile/status migration.
That migration moved reads from the deprecated trait fields to the resource
itself (
r.GetProfile()). That is correct for data written by a connector whichhas already migrated, but it returns nothing for data synced before the
migration, where the profile still lives on the trait annotation.
baton-sdk provides compatibility getters for exactly this
(
pkg/types/resource/resource_attrs.go):GetProfile,GetStatus,GetCreatedAt, andGetIconread the resource-level attribute first and fallback to the deprecated trait field. This switches the reads to those helpers so
previously-synced data still resolves.
Reads only — the write side (
WithResourceProfile/WithResourceStatus) isunchanged. Reference: ConductorOne/baton-sql#143.
golangci-lint run ./...reports 0 issues and the package tests pass.