Skip to content

cxp-689 return not found on no such subteam #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agustin-conductor merged 1 commit into from
Jun 25, 2026
Merged

cxp-689 return not found on no such subteam #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions pkg/connector/client/helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,11 +155,9 @@ func MapSlackErrorToGRPCCode(slackError string) codes.Code {
return codes.NotFound
}

// no_such_subteam is returned when fetching user group members. We determined
// empirically that retrying on this error allows syncs to complete successfully,
// so we map it to Unavailable to trigger the SDK's automatic retry logic.
// no_such_subteam is returned when fetching user group members. return NotFound to indicate the group is disabled or deleted.
if containsAny(err, SlackErrNoSuchSubteam) {
return codes.Unavailable
return codes.NotFound
}

if containsAny(err, "user_already_team_member") {
Expand Down
Loading