Skip to content

[OPS-1301] Delete legacy capabilities_and_config.yaml (duplicate) - #91

Merged
ennyjfrick merged 1 commit into
mainfrom
ennyfrick/ops-1301-delete-legacy-cac
May 4, 2026
Merged

[OPS-1301] Delete legacy capabilities_and_config.yaml (duplicate)#91
ennyjfrick merged 1 commit into
mainfrom
ennyfrick/ops-1301-delete-legacy-cac

Conversation

@ennyjfrick

Copy link
Copy Markdown
Contributor

Why

This repo already has .github/workflows/generate-baton-metadata.yaml (the modern baton-admin-managed metadata workflow that already uses baton-ci/baton-deps app tokens after OPS-1300). The legacy capabilities_and_config.yaml runs the same generator separately, auto-commits the same files (baton_capabilities.json, config_schema.json) to main, and still references RELENG_GITHUB_TOKEN.

Two workflows pushing the same files to main causes redundant runs at best and merge conflicts at worst. Delete the legacy one.

What

Removes .github/workflows/capabilities_and_config.yaml. The modern generate-baton-metadata.yaml continues to do the same job.

Linear: OPS-1301

🤖 Generated with Claude Code

…enerate-baton-metadata.yaml)

This repo already has generate-baton-metadata.yaml (managed by baton-admin)
which generates the same baton_capabilities.json + config_schema.json
output. The legacy capabilities_and_config.yaml is a duplicate that
auto-commits to main with the long-lived RELENG_GITHUB_TOKEN PAT — both
unwanted now that OPS-1300 is in place.

Linear: https://linear.app/ductone/issue/OPS-1301

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@ennyjfrick
ennyjfrick requested a review from a team April 30, 2026 16:41
@linear

linear Bot commented Apr 30, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Claude finished @ennyjfrick's task in 33s —— View job


PR Review: Delete legacy capabilities_and_config.yaml

  • Gather context and review PR changes
  • Verify the modern workflow exists and covers the same functionality
  • Post review feedback

LGTM — this is a clean, well-motivated deletion.

I verified that generate-baton-metadata.yaml on main is a strict superset of the deleted capabilities_and_config.yaml:

Aspect Legacy (deleted) Modern (kept)
Trigger push to main push to main + pull_request
Auth RELENG_GITHUB_TOKEN secret baton-ci app token
Build + generate go buildconfig + capabilities Same
Commit outputs EndBug/add-and-commit@v9 Same
PR validation ✅ (metadata freshness + docs check)

Both workflows generate the same two files (config_schema.json, baton_capabilities.json) and commit them with the same message. Having both fire on push to main would indeed cause redundant runs or race conditions on the commit step.

No concerns — safe to merge.

@ennyjfrick
ennyjfrick merged commit b5b13c7 into main May 4, 2026
10 checks passed
@ennyjfrick
ennyjfrick deleted the ennyfrick/ops-1301-delete-legacy-cac branch May 4, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants