Vendor DPoP dpop_oauth2 with token retry and increased timeout - #709
Closed
c1-dev-bot[bot] wants to merge 1 commit into
Closed
Vendor DPoP dpop_oauth2 with token retry and increased timeout#709c1-dev-bot[bot] wants to merge 1 commit into
c1-dev-bot[bot] wants to merge 1 commit into
Conversation
![c1-dev-bot[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
Updates the vendored dpop_oauth2 module to include retry with exponential backoff and a configurable timeout for token requests. This addresses intermittent Unauthenticated errors during large syncs where the previous 30s hardcoded timeout was insufficient. The dpop_oauth2 module now defaults to 60s timeout with up to 3 retries on transient errors (deadline exceeded, connection errors). Vendors unreleased changes from ConductorOne/DPoP#9.
kans
reviewed
Mar 2, 2026
| ## explicit; go 1.23.4 | ||
| github.com/conductorone/dpop/integrations/dpop_grpc | ||
| # github.com/conductorone/dpop/integrations/dpop_oauth2 v0.2.3 | ||
| # github.com/conductorone/dpop/integrations/dpop_oauth2 v0.2.3 => github.com/conductorone/dpop/integrations/dpop_oauth2 v0.0.0-20260301063918-0af759dbf2b0 |
Contributor
There was a problem hiding this comment.
This must be a tagged release.
kans
requested changes
Mar 2, 2026
Contributor
|
This bot doesn't update pull requests. It's probably best to disable it so it stops wasting our time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dpop_oauth2module with retry logic and increased timeout for token requestsUnauthenticatederrors during large Lambda connector syncs (400K+ grants)Dependency Notice
This PR vendors unreleased changes from ConductorOne/DPoP#9.
Before merging this PR, the dependency PR must be reviewed, merged, and released. After the dependency is released, update
go.modto point to the released version, remove thereplacedirective, and re-vendor before merging.Context
During large Jira Cloud connector syncs, the Lambda connector intermittently fails to refresh its DPoP authentication token. The
Token()method indpop_oauth2had a hardcoded 30-second timeout with no retry logic. When HTTP POST requests to the auth endpoint exceeded this limit during network latency spikes, a singledeadline exceededimmediately propagated as anUnauthenticatedgRPC error.The upstream fix in the DPoP library adds:
WithTokenTimeoutoption (default 60s)WithMaxRetriesoption (default 3)Test plan
go build ./pkg/lambda/...compiles successfullyAutomated PR Notice
This PR was automatically created by c1-dev-bot as a potential implementation.
This code requires: