fix: mark connection-string as isSecret in config_schema - #25
Merged
Conversation
The MySQL connection-string embeds the database password (user:password@tcp(host)/db) and was not flagged secret, so it was stored and surfaced as plain config. Mark it secret. baton-mysql defines its config in Go and ships no committed config_schema.json, so the generated-schema fix is the field.WithIsSecret(true) option on the connection-string field; the schema is regenerated from this at build time. Co-authored-by: c1-squire-dev[bot] <c1-squire-dev[bot]@users.noreply.github.com>
Contributor
Connector PR Review: fix: mark connection-string as isSecret in config_schemaBlocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0 Review SummarySingle-line change adds Security IssuesNone found. Correctness IssuesNone found. SuggestionsNone. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marks the MySQL
connection-stringconfig field as a secret.Why
connection-string(user:password@tcp(host:port)/db) embeds the databasepassword but was not flagged secret, so it was stored and surfaced as plain
config. This adds
field.WithIsSecret(true)to the field definition incmd/baton-mysql/config.go.baton-mysql defines its config in Go and ships no committed
config_schema.jsonat the repo root;field.WithIsSecret(true)is thesource of truth that the generated schema is built from, so this single change
is the equivalent of the schema fix.
Review only — do not merge.